UX: puts more emphasis on the shared url on share panel (#7055)

This commit is contained in:
Joffrey JAFFEUX 2019-02-22 23:22:11 +01:00 committed by GitHub
parent 260398d706
commit 87f4ee13ef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 19 additions and 15 deletions

View File

@ -27,12 +27,12 @@ export default Ember.Component.extend({
topicTitle = escapeExpression(topicTitle);
if (type === "topic") {
return I18n.t("share.topic", { topicTitle });
return I18n.t("share.topic_html", { topicTitle });
}
if (postNumber) {
return I18n.t("share.post", { postNumber, postDate });
return I18n.t("share.post_html", { postNumber, postDate });
}
return I18n.t("share.topic", { topicTitle });
return I18n.t("share.topic_html", { topicTitle });
},
@computed("panel.model.shareUrl", "topic.shareUrl")

View File

@ -3,7 +3,7 @@
</div>
<div class="body">
{{input value=shareUrl class="topic-share-url"}}
{{textarea value=shareUrl class="topic-share-url"}}
<div class="topic-share-url-for-touch"><a></a></div>
<div class="sources">

View File

@ -646,11 +646,7 @@
background: $danger;
&.single-tab {
color: $primary;
background: none;
padding: s(1 0);
font-weight: 700;
font-size: $font-up-3;
display: none;
}
}
}

View File

@ -14,6 +14,11 @@
font-size: $font-0;
font-weight: normal;
margin-bottom: s(2);
.post-date {
color: $primary-medium;
font-size: $font-down-1;
}
}
}
@ -23,12 +28,15 @@
.topic-share-url {
width: 100%;
height: auto;
box-sizing: border-box;
}
.topic-share-url-for-touch {
width: 290px;
@extend .overflow-ellipsis;
a {
word-break: break-all;
font-size: $font-up-1;
}
}
.topic-share-url-for-touch,
@ -43,7 +51,7 @@
flex-direction: row;
.social-link {
font-size: $font-up-4;
font-size: $font-up-6;
margin-right: s(2);
}
}

View File

@ -135,8 +135,8 @@ en:
next_month: "Next Month"
placeholder: date
share:
topic: "<b>Topic</b>: %{topicTitle}"
post: "<b>Post #%{postNumber}</b>, %{postDate}"
topic_html: 'Topic: <span class="topic-title">%{topicTitle}</span>'
post_html: '<span class="post-number">Post #%{postNumber}</span>, <span class="post-date">%{postDate}</span>'
close: "close"
twitter: "Share this link on Twitter"
facebook: "Share this link on Facebook"