From 54e4ff34f8d84150cd9405f33f1bab45850e59e4 Mon Sep 17 00:00:00 2001 From: Viktor Benei Date: Thu, 2 Nov 2017 12:33:35 +0100 Subject: [PATCH] Fix "duplicate method" issue Fixing http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/DuplicateMethods Readers are defined (https://github.com/discourse/discourse/blob/master/lib/single_sign_on.rb#L61), so only writers have to be generated. --- lib/single_sign_on.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/single_sign_on.rb b/lib/single_sign_on.rb index ef5a47d7b19..ba8a9035946 100644 --- a/lib/single_sign_on.rb +++ b/lib/single_sign_on.rb @@ -8,7 +8,7 @@ class SingleSignOn NONCE_EXPIRY_TIME = 10.minutes attr_accessor(*ACCESSORS) - attr_accessor :sso_secret, :sso_url + attr_writer :sso_secret, :sso_url def self.sso_secret raise RuntimeError, "sso_secret not implemented on class, be sure to set it on instance"