diff --git a/app/assets/javascripts/discourse/dialects/bbcode_dialect.js b/app/assets/javascripts/discourse/dialects/bbcode_dialect.js
index fe27c9c0a3d..d04f675de68 100644
--- a/app/assets/javascripts/discourse/dialects/bbcode_dialect.js
+++ b/app/assets/javascripts/discourse/dialects/bbcode_dialect.js
@@ -55,6 +55,20 @@ function replaceBBCodeParamsRaw(tag, emitter) {
});
}
+/**
+ Filters an array of JSON-ML nodes, removing nodes that represent empty lines ("\n").
+
+ @method removeEmptyLines
+ @param {Array} [contents] Array of JSON-ML nodes
+**/
+function removeEmptyLines(contents) {
+ var result = [];
+ for (var i=0; i < contents.length; i++) {
+ if (contents[i] !== "\n") { result.push(contents[i]); }
+ }
+ return result;
+}
+
/**
Creates a BBCode handler that accepts parameters. Passes them to the emitter.
Processes the inside recursively so it can be nested.
@@ -75,9 +89,9 @@ replaceBBCode('u', function(contents) { return ['span', {'class': 'bbcode-u'}].c
replaceBBCode('s', function(contents) { return ['span', {'class': 'bbcode-s'}].concat(contents); });
Discourse.Markdown.whiteListTag('span', 'class', /^bbcode-[bius]$/);
-replaceBBCode('ul', function(contents) { return ['ul'].concat(contents); });
-replaceBBCode('ol', function(contents) { return ['ol'].concat(contents); });
-replaceBBCode('li', function(contents) { return ['li'].concat(contents); });
+replaceBBCode('ul', function(contents) { return ['ul'].concat(removeEmptyLines(contents)); });
+replaceBBCode('ol', function(contents) { return ['ol'].concat(removeEmptyLines(contents)); });
+replaceBBCode('li', function(contents) { return ['li'].concat(removeEmptyLines(contents)); });
rawBBCode('img', function(contents) { return ['img', {href: contents}]; });
rawBBCode('email', function(contents) { return ['a', {href: "mailto:" + contents, 'data-bbcode': true}, contents]; });
diff --git a/app/assets/javascripts/discourse/dialects/code_dialect.js b/app/assets/javascripts/discourse/dialects/code_dialect.js
index 8f0ff739a27..5bb5d6b8b00 100644
--- a/app/assets/javascripts/discourse/dialects/code_dialect.js
+++ b/app/assets/javascripts/discourse/dialects/code_dialect.js
@@ -10,6 +10,15 @@ var acceptableCodeClasses =
"profile", "python", "r", "rib", "rsl", "ruby", "rust", "scala", "smalltalk", "sql", "tex", "text",
"vala", "vbscript", "vhdl"];
+function flattenBlocks(blocks) {
+ var result = "";
+ blocks.forEach(function(b) {
+ result += b;
+ if (b.trailing) { result += b.trailing; }
+ });
+ return result;
+}
+
Discourse.Dialect.replaceBlock({
start: /^`{3}([^\n\[\]]+)?\n?([\s\S]*)?/gm,
stop: '```',
@@ -19,7 +28,7 @@ Discourse.Dialect.replaceBlock({
if (matches[1] && acceptableCodeClasses.indexOf(matches[1]) !== -1) {
klass = matches[1];
}
- return ['p', ['pre', ['code', {'class': klass}, blockContents.join("\n") ]]];
+ return ['p', ['pre', ['code', {'class': klass}, flattenBlocks(blockContents) ]]];
}
});
@@ -50,6 +59,6 @@ Discourse.Dialect.replaceBlock({
skipIfTradtionalLinebreaks: true,
emitter: function(blockContents) {
- return ['p', ['pre', blockContents.join("\n")]];
+ return ['p', ['pre', flattenBlocks(blockContents)]];
}
});
diff --git a/app/assets/javascripts/discourse/dialects/dialect.js b/app/assets/javascripts/discourse/dialects/dialect.js
index 495d0fa6720..663e7205c6b 100644
--- a/app/assets/javascripts/discourse/dialects/dialect.js
+++ b/app/assets/javascripts/discourse/dialects/dialect.js
@@ -133,6 +133,19 @@ function invalidBoundary(args, prev) {
if (args.spaceOrTagBoundary && (!last.match(/(\s|\>)$/))) { return true; }
}
+/**
+ Returns the number of (terminated) lines in a string.
+
+ @method countLines
+ @param {string} str the string.
+ @returns {Integer} number of terminated lines in str
+**/
+function countLines(str) {
+ var index = -1, count = 0;
+ while ((index = str.indexOf("\n", index + 1)) !== -1) { count++; }
+ return count;
+}
+
/**
An object used for rendering our dialects.
@@ -288,7 +301,7 @@ Discourse.Dialect = {
this.registerInline(start, function(text, match, prev) {
if (invalidBoundary(args, prev)) { return; }
- var endPos = self.findEndPos(text, stop, args, startLength);
+ var endPos = self.findEndPos(text, start, stop, args, startLength);
if (endPos === -1) { return; }
var between = text.slice(startLength, endPos);
@@ -304,13 +317,14 @@ Discourse.Dialect = {
});
},
- findEndPos: function(text, stop, args, start) {
- var endPos = text.indexOf(stop, start);
- if (endPos === -1) { return -1; }
- var after = text.charAt(endPos + stop.length);
- if (after && after.indexOf(stop) === 0) {
- return this.findEndPos(text, stop, args, endPos + stop.length + 1);
- }
+ findEndPos: function(text, start, stop, args, offset) {
+ var endPos, nextStart;
+ do {
+ endPos = text.indexOf(stop, offset);
+ if (endPos === -1) { return -1; }
+ nextStart = text.indexOf(start, offset);
+ offset = endPos + stop.length;
+ } while (nextStart !== -1 && nextStart < endPos);
return endPos;
},
@@ -358,102 +372,83 @@ Discourse.Dialect = {
var linebreaks = dialect.options.traditional_markdown_linebreaks ||
Discourse.SiteSettings.traditional_markdown_linebreaks;
-
- // Some replacers should not be run with traditional linebreaks
if (linebreaks && args.skipIfTradtionalLinebreaks) { return; }
args.start.lastIndex = 0;
- var m = (args.start).exec(block);
+ var result = [], match = (args.start).exec(block);
+ if (!match) { return; }
- if (!m) { return; }
+ var lastChance = function() {
+ return !next.some(function(e) { return e.indexOf(args.stop) !== -1; });
+ };
- var startPos = args.start.lastIndex - m[0].length,
- leading,
- blockContents = [],
- result = [],
- lineNumber = block.lineNumber;
-
- if (startPos > 0) {
- leading = block.slice(0, startPos);
- lineNumber += (leading.split("\n").length - 1);
-
- var para = ['p'];
- this.processInline(leading).forEach(function (l) {
- para.push(l);
- });
-
- result.push(para);
+ // shave off start tag and leading text, if any.
+ var pos = args.start.lastIndex - match[0].length,
+ leading = block.slice(0, pos),
+ trailing = match[2] ? match[2].replace(/^\n*/, "") : "";
+ // just give up if there's no stop tag in this or any next block
+ if (block.indexOf(args.stop, pos + args.stop.length) === -1 && lastChance()) { return; }
+ if (leading.length > 0) { result.push(['p'].concat(this.processInline(leading))); }
+ if (trailing.length > 0) {
+ next.unshift(MD.mk_block(trailing, block.trailing,
+ block.lineNumber + countLines(leading) + (match[2] ? match[2].length : 0) - trailing.length));
}
- if (m[2]) {
- next.unshift(MD.mk_block(m[2], null, lineNumber + 1));
- }
+ // go through the available blocks to find the matching stop tag.
+ var contentBlocks = [], nesting = 0, actualEndPos = -1, currentBlock;
+ blockloop:
+ while (currentBlock = next.shift()) {
+ // collect all the start and stop tags in the current block
+ args.start.lastIndex = 0;
+ var startPos = [], m;
+ while (m = (args.start).exec(currentBlock)) {
+ startPos.push(args.start.lastIndex - m[0].length);
+ args.start.lastIndex = args.start.lastIndex - (m[2] ? m[2].length : 0);
+ }
+ var endPos = [], offset = 0;
+ while ((pos = currentBlock.indexOf(args.stop, offset)) !== -1) {
+ endPos.push(pos);
+ offset += (pos + args.stop.length);
+ }
- lineNumber++;
+ // go through the available end tags:
+ var ep = 0, sp = 0; // array indices
+ while (ep < endPos.length) {
+ if (sp < startPos.length && startPos[sp] < endPos[ep]) {
+ // there's an end tag, but there's also another start tag first. we need to go deeper.
+ sp++; nesting++;
+ } else if (nesting > 0) {
+ // found an end tag, but we must go up a level first.
+ ep++; nesting--;
+ } else {
+ // found an end tag and we're at the top: done!
+ actualEndPos = endPos[ep];
+ break blockloop;
+ }
+ }
- var blockClosed = false;
- for (var i=0; i abc hello [quote=\"Bob, post:2, topic:1\"] \"hello "hello "evil" trout" ["text"
", "creates an ul");
format("[ol][li]option one[/li][/ol]", "
", "creates an ol");
+ format("[ul]\n[li]option one[/li]\n[li]option two[/li]\n[/ul]", "
", "suppresses empty lines in lists");
});
test('tags with arguments', function() {
@@ -127,6 +129,16 @@ test("quote formatting", function() {
"
\n\n
world\"\nhello\n
\n",
- "\nhello
hello", "pre blocks don't include extra lines"); cooked("```\na\nb\nc\n\nd\n```", diff --git a/vendor/assets/javascripts/better_markdown.js b/vendor/assets/javascripts/better_markdown.js index 732764d8cfd..017cb414da1 100644 --- a/vendor/assets/javascripts/better_markdown.js +++ b/vendor/assets/javascripts/better_markdown.js @@ -662,7 +662,7 @@ return [consumed, null, nodes]; } - var res = this.dialect.inline.__oneElement__.call(this, text.substr( consumed ), patterns ); + var res = this.dialect.inline.__oneElement__.call(this, text.substr( consumed ), patterns, [text.substr(0, consumed)]); consumed += res[ 0 ]; // Add any returned nodes. nodes.push.apply( nodes, res.slice( 1 ) );