Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: Detect firefox < 89 as an unsupported browser (#17443) 

Prior to v89, Firefox has bugs with document.execCommand("insertText"): https://bugzil.la/1220696

This commit introduces some variables to browser-detect, and therefore wraps the entire logic in an IIFE to avoid state leaking. (`let`/`const` are not supported on older browsers)
This commit is contained in:
David Taylor 2022-07-12 10:50:06 +01:00 committed by GitHub
parent 6c3e262a7c
commit 8a68f49adb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
app/assets/javascripts/discourse/scripts/browser-detect.js
View File

@ -1,12 +1,24 @@
if (!window.WeakMap || !window.Promise || typeof globalThis === "undefined") {
window.unsupportedBrowser = true;
} else {
// Some implementations of `WeakMap.prototype.has` do not accept false
// values and Ember's `isClassicDecorator` sometimes does that (it only
// checks for `null` and `undefined`).
try {
new WeakMap().has(0);
} catch (err) {
/* eslint-disable no-var */ // `let` is not supported in very old browsers
(function () {
if (!window.WeakMap || !window.Promise || typeof globalThis === "undefined") {
window.unsupportedBrowser = true;
} else {
// Some implementations of `WeakMap.prototype.has` do not accept false
// values and Ember's `isClassicDecorator` sometimes does that (it only
// checks for `null` and `undefined`).
try {
new WeakMap().has(0);
} catch (err) {
window.unsupportedBrowser = true;
}
var match = window.navigator.userAgent.match(/Firefox\/([0-9]+)\./);
var firefoxVersion = match ? parseInt(match[1], 10) : null;
if (firefoxVersion && firefoxVersion < 89) {
// prior to v89, Firefox has bugs with document.execCommand("insertText")
// https://bugzil.la/1220696
window.unsupportedBrowser = true;
}
}
}
})();