From 8a9d3b3eed7c96110ed7af4f7842aabe47e73baa Mon Sep 17 00:00:00 2001 From: Alan Guo Xiang Tan Date: Mon, 29 May 2023 16:03:49 +0900 Subject: [PATCH] DEV: Skip flaky system tests on CI (#undefined) --- spec/system/admin_customize_form_templates_spec.rb | 4 ++++ spec/system/user_preferences_interface_spec.rb | 9 +++++++++ 2 files changed, 13 insertions(+) diff --git a/spec/system/admin_customize_form_templates_spec.rb b/spec/system/admin_customize_form_templates_spec.rb index c5751453ef4..f57d4092a39 100644 --- a/spec/system/admin_customize_form_templates_spec.rb +++ b/spec/system/admin_customize_form_templates_spec.rb @@ -10,6 +10,10 @@ describe "Admin Customize Form Templates", type: :system, js: true do end before do + skip(<<~TEXT) if ENV["CI"] + The specs here are extremely flaky on CI for some reason. + TEXT + SiteSetting.experimental_form_templates = true sign_in(admin) end diff --git a/spec/system/user_preferences_interface_spec.rb b/spec/system/user_preferences_interface_spec.rb index 52137d06d62..859c3b8cb6a 100644 --- a/spec/system/user_preferences_interface_spec.rb +++ b/spec/system/user_preferences_interface_spec.rb @@ -9,6 +9,15 @@ describe "User preferences for Interface", type: :system, js: true do describe "Bookmarks" do it "changes the bookmark after notification preference" do + skip(<<~TEXT) if ENV["CI"] + This is currently failing on CI with the following: + + ``` + Failure/Error: expect(page).to have_content(I18n.t("js.saved")) + expected `#.has_content?("Saved!")` to be truthy, got false + ``` + TEXT + user_preferences_page.visit(user).click_interface_tab # preselects the default user_option.bookmark_auto_delete_preference value of 3 (clear_reminder)