Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: Detect DiscourseHub user agent. 

It used to show up as an unknown device and browser in user preferences
(Recently Used Devices).
This commit is contained in:
Dan Ungureanu 2019-08-09 11:56:48 +03:00
parent 1f47ed1ea3
commit 8aa5df69f0
No known key found for this signature in database
GPG Key ID: 0AA2A00D6ACC8B84
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/browser_detection.rb
View File

@ -16,7 +16,7 @@ module BrowserDetection
:safari
when /MSIE/i, /Trident/i
:ie
when /DiscourseHub/i
when /Discourse/i
:discoursehub
else
:unknown
@ -54,7 +54,7 @@ module BrowserDetection
:android
when /CrOS/i
:chromeos
when /iPhone|iPad|iPod/i
when /iPhone|iPad|iPod|Darwin/i
:ios
when /Macintosh/i
:macos

3
spec/lib/browser_detection_spec.rb
View File

@ -31,7 +31,8 @@ describe BrowserDetection do
["Opera/9.80 (X11; Linux zvav; U; en) Presto/2.12.423 Version/12.16", :opera, :linux, :linux],
["Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36 Edge/12.246", :edge, :windows, :windows],
["Mozilla/5.0 (X11; CrOS x86_64 11895.95.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.125 Safari/537.36 ", :chrome, :chromebook, :chromeos],
["Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36 Edg/75.10240", :edge, :windows, :windows]
["Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36 Edg/75.10240", :edge, :windows, :windows],
["Discourse/163 CFNetwork/978.0.7 Darwin/18.6.0", :discoursehub, :unknown, :ios]
].each do |user_agent, browser, device, os|
expect(BrowserDetection.browser(user_agent)).to eq(browser)
expect(BrowserDetection.device(user_agent)).to eq(device)