From 8c4896f6609bfa565fd419744042420a39035a02 Mon Sep 17 00:00:00 2001 From: Arpit Jalan Date: Mon, 15 Nov 2021 17:12:06 +0530 Subject: [PATCH] FIX: composer education message for group mentions were broken (#14937) Composer education message for group mentions were broken because the count parameter is a string instead of a number. --- .../javascripts/discourse/app/controllers/composer.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/assets/javascripts/discourse/app/controllers/composer.js b/app/assets/javascripts/discourse/app/controllers/composer.js index 4bf6c9e07de..47a8fc8abd5 100644 --- a/app/assets/javascripts/discourse/app/controllers/composer.js +++ b/app/assets/javascripts/discourse/app/controllers/composer.js @@ -675,17 +675,19 @@ export default Controller.extend({ groups.forEach((group) => { let body; const groupLink = getURL(`/g/${group.name}/members`); + const maxMentions = parseInt(group.max_mentions, 10); + const userCount = parseInt(group.user_count, 10); - if (group.max_mentions < group.user_count) { + if (maxMentions < userCount) { body = I18n.t("composer.group_mentioned_limit", { group: `@${group.name}`, - count: group.max_mentions, + count: maxMentions, group_link: groupLink, }); } else if (group.user_count > 0) { body = I18n.t("composer.group_mentioned", { group: `@${group.name}`, - count: group.user_count, + count: userCount, group_link: groupLink, }); }