Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

UX: improve semantic of login button for better password managers compatibility

This commit is contained in:
Régis Hanol 2018-01-31 20:09:59 +01:00
parent c598db28e7
commit 8c91d418dd
2 changed files with 11 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
app/assets/javascripts/discourse/templates/modal/login.hbs
View File

@ -6,24 +6,14 @@
<div> <div>
<table> <table>
<tr> <tr>
<td> <td><label for='login-account-name'>{{i18n 'login.username'}}</label></td>
<label for='login-account-name'>{{i18n 'login.username'}}&nbsp;</label> <td>{{text-field value=loginName placeholderKey="login.email_placeholder" id="login-account-name" autocorrect="off" autocapitalize="off" autofocus="autofocus"}}</td>
</td>
<td>
{{text-field value=loginName placeholderKey="login.email_placeholder" id="login-account-name" autocorrect="off" autocapitalize="off" autofocus="autofocus"}}
</td>
<td></td> <td></td>
</tr> </tr>
<tr> <tr>
<td> <td><label for='login-account-password'>{{i18n 'login.password'}}</label></td>
<label for='login-account-password'>{{i18n 'login.password'}}&nbsp;</label> <td>{{password-field value=loginPassword type="password" id="login-account-password" maxlength="200" capsLockOn=capsLockOn}}</td>
</td> <td><a id="forgot-password-link" {{action "forgotPassword"}}>{{i18n 'forgot_password.action'}}</a></td>
<td>
{{password-field value=loginPassword type="password" id="login-account-password" maxlength="200" capsLockOn=capsLockOn}} &nbsp;
</td>
<td>
<a id="forgot-password-link" {{action "forgotPassword"}}>{{i18n 'forgot_password.action'}}</a>
</td>
</tr> </tr>
<tr> <tr>
<td></td> <td></td>
@ -40,14 +30,11 @@
<div class="modal-footer"> <div class="modal-footer">
{{#if canLoginLocal}} {{#if canLoginLocal}}
<button class="btn btn-large btn-primary" <button form="login-form" type="submit" class="btn btn-large btn-primary" disabled={{loginDisabled}} {{action "login"}}>
disabled={{loginDisabled}} {{d-icon "unlock"}}&nbsp;{{loginButtonText}}
{{action "login"}}>
{{d-icon "unlock"}} &nbsp;{{loginButtonText}}
</button> </button>
{{#if showSignupLink}} {{#if showSignupLink}}
&nbsp;
<button class="btn btn-large" id="new-account-link" {{action "createAccount"}}> <button class="btn btn-large" id="new-account-link" {{action "createAccount"}}>
{{i18n 'create_account.title'}} {{i18n 'create_account.title'}}
</button> </button>
@ -55,7 +42,7 @@
{{/if}} {{/if}}
{{#if authenticate}} {{#if authenticate}}
&nbsp; {{i18n 'login.authenticating'}} &nbsp;{{i18n 'login.authenticating'}}
{{/if}} {{/if}}
{{conditional-loading-spinner condition=showSpinner size="small"}} {{conditional-loading-spinner condition=showSpinner size="small"}}

3
app/assets/stylesheets/desktop/login.scss
View File

@ -16,6 +16,9 @@
a { a {
color: dark-light-choose($primary-high, $secondary-low); color: dark-light-choose($primary-high, $secondary-low);
} }
td {
padding-right: 5px;
}
} }
// Create account // Create account