From 8d2908dd9e12f309a442bd3a1ae92d48938f5427 Mon Sep 17 00:00:00 2001
From: Arpit Jalan <arpit@techapj.com>
Date: Wed, 27 May 2020 21:53:59 +0530
Subject: [PATCH] UX: do not show redundant user count

UX: add spacing between +member_count and "more"
---
 .../app/components/group-card-contents.js     |  5 ----
 .../components/group-card-contents.hbs        | 24 ++-----------------
 2 files changed, 2 insertions(+), 27 deletions(-)

diff --git a/app/assets/javascripts/discourse/app/components/group-card-contents.js b/app/assets/javascripts/discourse/app/components/group-card-contents.js
index 2ff80e5b3ba..5f09b94b188 100644
--- a/app/assets/javascripts/discourse/app/components/group-card-contents.js
+++ b/app/assets/javascripts/discourse/app/components/group-card-contents.js
@@ -27,11 +27,6 @@ export default Component.extend(CardContentsBase, CleansUp, {
   viewingTopic: match("currentPath", /^topic\./),
 
   showMoreMembers: gt("moreMembersCount", 0),
-  hasMembersOrIsMember: or(
-    "group.members",
-    "group.is_group_owner_display",
-    "group.is_group_user"
-  ),
 
   group: null,
 
diff --git a/app/assets/javascripts/discourse/app/templates/components/group-card-contents.hbs b/app/assets/javascripts/discourse/app/templates/components/group-card-contents.hbs
index 3c867903a29..6c07de9a816 100644
--- a/app/assets/javascripts/discourse/app/templates/components/group-card-contents.hbs
+++ b/app/assets/javascripts/discourse/app/templates/components/group-card-contents.hbs
@@ -49,35 +49,15 @@
       </div>
     {{/if}}
 
-    {{#if hasMembersOrIsMember}}
-      <div class="card-row third-row">
-        <div class="metadata">
-          <h3>
-            <span class="desc">
-              {{i18n "groups.user_count"}}
-            </span>
-            {{group.user_count}}
-          </h3>
-          <h3>
-            {{#if group.is_group_owner_display}}
-              {{i18n "groups.index.is_group_owner"}}
-            {{else if group.is_group_user}}
-              {{i18n "groups.index.is_group_user"}}
-            {{/if}}
-          </h3>
-        </div>
-      </div>
-    {{/if}}
-
     {{#if group.members}}
-      <div class="card-row fourth-row">
+      <div class="card-row third-row">
         <div class="members metadata">
           {{#each group.members as |user|}}
             <a href {{action "showUser" user}} class="card-tiny-avatar">{{bound-avatar user "tiny"}}</a>
           {{/each}}
           {{#if showMoreMembers}}
             <a href={{groupPath}} {{action "showGroup" group}} class="more-members-link">
-              <span class="more-members-count">+{{moreMembersCount}}{{i18n "more"}}</span>
+              <span class="more-members-count">+{{moreMembersCount}} {{i18n "more"}}</span>
             </a>
           {{/if}}
         </div>