Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

UX: Add missing title to notifications-button (#27837) 

This commit adds the missing title for notifications-button. In the past, it was automatically fallbacked to the button's key.

Related meta topic: https://meta.discourse.org/t/tracking-toggle-text-on-hover-sometimes-not-translated/315727
This commit is contained in:
锦心 2024-07-11 08:37:53 +08:00 committed by GitHub
parent 8c5553448a
commit 8d6a2aad18
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
app/assets/javascripts/select-kit/addon/components/notifications-button.js
View File

@ -16,16 +16,23 @@ export default DropdownSelectBoxComponent.extend({
i18nPostfix: "",
},
modifyComponentForRow() {
getTitle(key) {
const { i18nPrefix, i18nPostfix } = this.selectKit.options;
return I18n.t(`${i18nPrefix}.${key}${i18nPostfix}.title`);
},
modifyComponentForRow(_, content) {
if (content) {
setProperties(content, {
title: this.getTitle(content.key),
});
}
return "notifications-button/notifications-button-row";
},
modifySelection(content) {
content = content || {};
const { i18nPrefix, i18nPostfix } = this.selectKit.options;
const title = I18n.t(
`${i18nPrefix}.${this.buttonForValue.key}${i18nPostfix}.title`
);
const title = this.getTitle(this.buttonForValue.key);
setProperties(content, {
title,
label: title,