DEV: Minor linting fixes (#16359)
1. `test/run-qunit.js` wasn't eslinted (I'm not adding it to the CI workflow for now, just fixed the issues) 2. "…" utf character isn't rendered correctly in Jenkins, replaced with three dots 3. Don't try to lint `tmp` when doing `eslint .` in the root dir
This commit is contained in:
parent
b20307377a
commit
9060a045c2
|
@ -16,3 +16,4 @@ app/assets/javascripts/discourse/tests/test-boot-rails.js
|
|||
app/assets/javascripts/discourse/tests/fixtures
|
||||
node_modules/
|
||||
dist/
|
||||
tmp/
|
||||
|
|
|
@ -82,7 +82,7 @@ task "smoke:test" do
|
|||
|
||||
next if api_key.blank? && api_username.blank? && theme_url.blank?
|
||||
|
||||
puts "Running QUnit tests for theme #{theme_url.inspect} using API key #{api_key[0..3]}… and username #{api_username.inspect}"
|
||||
puts "Running QUnit tests for theme #{theme_url.inspect} using API key #{api_key[0..3]}... and username #{api_username.inspect}"
|
||||
|
||||
query_params = {
|
||||
seed: Random.new.seed,
|
||||
|
|
|
@ -128,7 +128,7 @@ async function runAllTests() {
|
|||
const urlObj = new URL(url);
|
||||
Fetch.requestPaused((data) => {
|
||||
const requestURL = new URL(data.request.url);
|
||||
if (requestURL.hostname != urlObj.hostname) {
|
||||
if (requestURL.hostname !== urlObj.hostname) {
|
||||
Fetch.continueRequest({
|
||||
requestId: data.requestId,
|
||||
});
|
||||
|
@ -207,6 +207,7 @@ runAllTests().catch((e) => {
|
|||
// The following functions are converted to strings
|
||||
// And then sent to chrome to be evaluated
|
||||
function logQUnit() {
|
||||
const QUnit = window.QUnit;
|
||||
let testErrors = [];
|
||||
let assertionErrors = [];
|
||||
|
||||
|
@ -319,6 +320,7 @@ function logQUnit() {
|
|||
|
||||
window.qunitDone = context;
|
||||
});
|
||||
|
||||
QUnit.start();
|
||||
}
|
||||
let qunit_script = logQUnit.toString();
|
||||
|
|
Loading…
Reference in New Issue