From 90b900704b5f9fff3a513b0bf6b897b15c44ce54 Mon Sep 17 00:00:00 2001 From: Penar Musaraj Date: Mon, 11 May 2020 16:54:52 -0400 Subject: [PATCH] FIX: Improve mobile footer nav accessibility --- .../javascripts/discourse/app/widgets/footer-nav.js | 12 ++++++++---- config/locales/client.en.yml | 6 ++++++ 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/app/assets/javascripts/discourse/app/widgets/footer-nav.js b/app/assets/javascripts/discourse/app/widgets/footer-nav.js index 92c90263dad..4ff85830a62 100644 --- a/app/assets/javascripts/discourse/app/widgets/footer-nav.js +++ b/app/assets/javascripts/discourse/app/widgets/footer-nav.js @@ -12,7 +12,8 @@ createWidget("footer-nav", { action: "goBack", icon: "chevron-left", className: "btn-large", - disabled: !attrs.canGoBack + disabled: !attrs.canGoBack, + title: "footer_nav.back" }) ); @@ -21,7 +22,8 @@ createWidget("footer-nav", { action: "goForward", icon: "chevron-right", className: "btn-large", - disabled: !attrs.canGoForward + disabled: !attrs.canGoForward, + title: "footer_nav.forward" }) ); @@ -30,7 +32,8 @@ createWidget("footer-nav", { this.attach("flat-button", { action: "share", icon: "link", - className: "btn-large" + className: "btn-large", + title: "footer_nav.share" }) ); @@ -38,7 +41,8 @@ createWidget("footer-nav", { this.attach("flat-button", { action: "dismiss", icon: "chevron-down", - className: "btn-large" + className: "btn-large", + title: "footer_nav.dismiss" }) ); } diff --git a/config/locales/client.en.yml b/config/locales/client.en.yml index 2d60c1b2846..5d49c7492d9 100644 --- a/config/locales/client.en.yml +++ b/config/locales/client.en.yml @@ -3319,6 +3319,12 @@ en: forced_anonymous: "Due to extreme load, this is temporarily being shown to everyone as a logged out user would see it." + footer_nav: + back: "Back" + forward: "Forward" + share: "Share" + dismiss: "Dismiss" + safe_mode: enabled: "Safe mode is enabled, to exit safe mode close this browser window"