Remove unnecessary computed property.

app/assets/javascripts/discourse/components/search-advanced-options.js.es6

@@ -388,11 +388,6 @@ export default Em.Component.extend({
     return (this.get('isExpanded')) ? "fa-caret-down" : "fa-caret-right";
   }.property('isExpanded'),
 
-  @computed('isExpanded')
-  isCollapsed(isExpanded){
-    return !isExpanded;
-  },
-
   actions: {
     expandOptions() {
       this.set('isExpanded', !this.get('isExpanded'));

app/assets/javascripts/discourse/templates/components/search-advanced-options.hbs

@@ -1,7 +1,7 @@
 <h3 class="panel-title" {{action "expandOptions"}}>
   <i class="fa {{collapsedClassName}}"></i> {{i18n "search.advanced.title"}}
 </h3>
-{{#unless isCollapsed}}
+{{#if isExpanded}}
   <div class="search-options">
     <div class="container">
       <div class="control-group pull-left">
@@ -18,7 +18,7 @@
       </div>
     </div>
 
-    <!-- disable these super-advanced searches for now 
+    <!-- disable these super-advanced searches for now
     <div class="container">
       <div class="control-group pull-left">
         <label class="control-label" for="search-in-group">{{i18n "search.advanced.in_group.label"}}</label>
@@ -33,7 +33,7 @@
         </div>
       </div>
     </div>
-    --> 
+    -->
 
     {{#if siteSettings.tagging_enabled}}
       <div class="container">
@@ -77,4 +77,4 @@
       </div>
     </div>
   </div>
-{{/unless}}
+{{/if}}