UX: clean up some label and form inconsistencies, reduce excess bolding (#25701)

app/assets/javascripts/admin/addon/components/watched-word-form.hbs

@@ -66,7 +66,7 @@
   <label for="watched-case-sensitivity">{{i18n
       "admin.watched_words.form.case_sensitivity_label"
     }}</label>
-  <label class="case-sensitivity-checkbox">
+  <label class="case-sensitivity-checkbox checkbox-label">
     <Input
       @type="checkbox"
       @checked={{this.isCaseSensitive}}

app/assets/javascripts/admin/addon/templates/admin-badges/show.hbs

@@ -236,7 +236,7 @@
       </div>
 
       <div>
-        <label>
+        <label class="checkbox-label">
           <Input
             @type="checkbox"
             @checked={{this.buffered.multiple_grant}}
@@ -247,7 +247,7 @@
       </div>
 
       <div>
-        <label>
+        <label class="checkbox-label">
           <Input
             @type="checkbox"
             @checked={{this.buffered.listable}}
@@ -258,7 +258,7 @@
       </div>
 
       <div>
-        <label>
+        <label class="checkbox-label">
           <Input
             @type="checkbox"
             @checked={{this.buffered.show_posts}}

app/assets/javascripts/admin/addon/templates/site-text-index.hbs

@@ -32,7 +32,7 @@
       />
     </div>
 
-    <label>
+    <label class="checkbox-label">
       <input
         id="toggle-overridden"
         type="checkbox"
@@ -42,7 +42,7 @@
       {{i18n "admin.site_text.show_overriden"}}
     </label>
 
-    <label>
+    <label class="checkbox-label">
       <input
         id="toggle-outdated"
         type="checkbox"

app/assets/javascripts/discourse/app/components/group-flair-inputs.hbs

@@ -11,7 +11,7 @@
         @value="icon"
         @selection={{this.model.flair_type}}
       />
-      <b>{{i18n "groups.flair_type.icon"}}</b>
+      {{i18n "groups.flair_type.icon"}}
     </label>
 
     <label class="radio-label" for="avatar-flair-image">
@@ -21,7 +21,7 @@
         @value="image"
         @selection={{this.model.flair_type}}
       />
-      <b>{{i18n "groups.flair_type.image"}}</b>
+      {{i18n "groups.flair_type.image"}}
     </label>
   </div>
 

app/assets/javascripts/discourse/app/components/search-advanced-options.hbs

@@ -85,7 +85,7 @@
                   )
                 }}
               />
-              <label for="matching-title-only">
+              <label class="checkbox-label" for="matching-title-only">
                 {{i18n "search.advanced.filters.title"}}
               </label>
             </div>
@@ -103,7 +103,7 @@
                   )
                 }}
               />
-              <label for="matching-liked">{{i18n
+              <label class="checkbox-label" for="matching-liked">{{i18n
                   "search.advanced.filters.likes"
                 }}</label>
             </div>
@@ -122,7 +122,7 @@
                   )
                 }}
               />
-              <label for="matching-in-messages">{{i18n
+              <label class="checkbox-label" for="matching-in-messages">{{i18n
                   "search.advanced.filters.private"
                 }}</label>
             </div>
@@ -140,7 +140,7 @@
                   )
                 }}
               />
-              <label for="matching-seen">{{i18n
+              <label class="checkbox-label" for="matching-seen">{{i18n
                   "search.advanced.filters.seen"
                 }}</label>
             </div>

app/assets/javascripts/discourse/app/templates/review-index.hbs

@@ -18,7 +18,9 @@
 
   <div class="reviewable-filters">
     <div class="reviewable-filter">
-      <label class="filter-label">{{i18n "review.filters.status"}}</label>
+      <label class="filter-label">
+        {{i18n "review.filters.status"}}
+      </label>
       <ComboBox
         @value={{this.filterStatus}}
         @content={{this.statuses}}
@@ -40,7 +42,9 @@
       </span>
 
       <div class="reviewable-filter">
-        <label class="filter-label">{{i18n "review.filters.type.title"}}</label>
+        <label class="filter-label">
+          {{i18n "review.filters.type.title"}}
+        </label>
         <ComboBox
           @value={{this.filterType}}
           @content={{this.allTypes}}
@@ -50,9 +54,9 @@
       </div>
 
       <div class="reviewable-filter">
-        <label class="filter-label">{{i18n
-            "review.filters.priority.title"
-          }}</label>
+        <label class="filter-label">
+          {{i18n "review.filters.priority.title"}}
+        </label>
         <ComboBox
           @value={{this.filterPriority}}
           @content={{this.priorities}}
@@ -61,7 +65,9 @@
       </div>
 
       <div class="reviewable-filter">
-        <label class="filter-label">{{i18n "review.filters.category"}}</label>
+        <label class="filter-label">
+          {{i18n "review.filters.category"}}
+        </label>
         <CategoryChooser
           @value={{this.filterCategoryId}}
           @onChange={{action (mut this.filterCategoryId)}}
@@ -70,7 +76,9 @@
       </div>
 
       <div class="reviewable-filter topic-filter">
-        {{i18n "review.filtered_reviewed_by"}}
+        <label class="filter-label">
+          {{i18n "review.filtered_reviewed_by"}}
+        </label>
         <EmailGroupUserChooser
           @value={{this.filterReviewedBy}}
           @onChange={{action "updateFilterReviewedBy"}}
@@ -83,7 +91,9 @@
       </div>
 
       <div class="reviewable-filter topic-filter">
-        {{i18n "review.filtered_user"}}
+        <label class="filter-label">
+          {{i18n "review.filtered_user"}}
+        </label>
         <EmailGroupUserChooser
           @value={{this.filterUsername}}
           @onChange={{action "updateFilterUsername"}}
@@ -98,7 +108,9 @@
 
       {{#if this.filterTopic}}
         <div class="reviewable-filter topic-filter">
-          {{i18n "review.filtered_topic"}}
+          <label class="filter-label">
+            {{i18n "review.filtered_topic"}}
+          </label>
           <DButton
             @label="review.show_all_topics"
             @icon="times"
@@ -109,7 +121,9 @@
       {{/if}}
 
       <div class="reviewable-filter date-range">
-        {{i18n "review.date_filter"}}
+        <label class="filter-label">
+          {{i18n "review.date_filter"}}
+        </label>
         <DateTimeInputRange
           @from={{this.filterFromDate}}
           @to={{this.filterToDate}}
@@ -120,7 +134,9 @@
       </div>
 
       <div class="reviewable-filter sort-order">
-        {{i18n "review.order_by"}}
+        <label class="filter-label">
+          {{i18n "review.order_by"}}
+        </label>
         <ComboBox
           @value={{this.filterSortOrder}}
           @content={{this.sortOrders}}

app/assets/stylesheets/common/admin/admin_emojis.scss

@@ -7,7 +7,6 @@
     text-align: right;
   }
   #emoji-uploader {
-    padding: 10px;
     transition: box-shadow ease-in-out 0.25s;
   }
   .uppy-is-drag-over {

app/assets/stylesheets/common/admin/backups.scss

@@ -107,4 +107,7 @@ button.ru {
       margin: 1.25em 0 0;
     }
   }
+  label {
+    font-weight: normal;
+  }
 }

app/assets/stylesheets/common/admin/staff_logs.scss

@@ -282,6 +282,9 @@ table.screened-ip-addresses {
 
 .watched-words-uploader {
   display: inline-block;
+  label {
+    font-weight: normal;
+  }
 }
 
 .watched-words-list {

app/assets/stylesheets/common/base/discourse.scss

@@ -140,6 +140,11 @@ span.relative-date {
   white-space: nowrap;
 }
 
+legend {
+  color: var(--primary-high);
+  font-weight: bold;
+}
+
 label {
   display: flex;
   margin-bottom: 5px;
@@ -587,8 +592,12 @@ textarea {
     line-height: var(--line-height-large);
   }
 
+  .control-group,
   .controls {
     margin-left: 0;
+    label {
+      font-weight: normal;
+    }
   }
 }
 

app/assets/stylesheets/common/base/search.scss

@@ -177,6 +177,10 @@
           background-color: var(--tertiary-very-low);
         }
       }
+      .control-label {
+        font-weight: bold;
+        color: var(--primary-high);
+      }
     }
 
     details.search-advanced-additional-options {

app/assets/stylesheets/common/base/user.scss

@@ -304,7 +304,6 @@
         width: auto;
         text-align: left;
         font-weight: normal;
-        font-weight: bold;
       }
 
       .instructions {

app/assets/stylesheets/common/components/sidebar/edit-navigation-menu/categories-modal.scss

@@ -35,6 +35,7 @@
     padding: 0.75em 1em;
     margin: 0;
     flex-grow: 1;
+    font-weight: normal;
     input[type="checkbox"] {
       margin-right: 0;
     }

app/assets/stylesheets/common/components/sidebar/edit-navigation-menu/tags-modal.scss

@@ -21,6 +21,7 @@
       margin-bottom: 0;
       min-width: 0;
       padding: 0.33em 0;
+      font-weight: normal;
       @include breakpoint(tablet) {
         // extra tappable space
         padding: 0.5em 0;
@@ -43,6 +44,5 @@
 
   .sidebar-tags-form__tag-label-count {
     color: var(--primary-medium);
-    margin-left: 0.33em;
   }
 }