diff --git a/plugins/discourse-narrative-bot/lib/discourse_narrative_bot/track_selector.rb b/plugins/discourse-narrative-bot/lib/discourse_narrative_bot/track_selector.rb index 7aa7449ff06..9d4c68fe1d3 100644 --- a/plugins/discourse-narrative-bot/lib/discourse_narrative_bot/track_selector.rb +++ b/plugins/discourse-narrative-bot/lib/discourse_narrative_bot/track_selector.rb @@ -217,9 +217,7 @@ module DiscourseNarrativeBot def skip_track? if @is_pm_to_bot post_raw = @post.raw - - post_raw.match(/^@#{self.discobot_user.username} #{self.class.skip_trigger}/i) || - post_raw.strip == self.class.skip_trigger + post_raw.match(/((^@#{self.discobot_user.username} #{self.class.skip_trigger})|(^#{self.class.skip_trigger}$))/i) else false end diff --git a/plugins/discourse-narrative-bot/spec/discourse_narrative_bot/advanced_user_narrative_spec.rb b/plugins/discourse-narrative-bot/spec/discourse_narrative_bot/advanced_user_narrative_spec.rb index 5c2eeb04523..c7ae6820614 100644 --- a/plugins/discourse-narrative-bot/spec/discourse_narrative_bot/advanced_user_narrative_spec.rb +++ b/plugins/discourse-narrative-bot/spec/discourse_narrative_bot/advanced_user_narrative_spec.rb @@ -162,7 +162,7 @@ RSpec.describe DiscourseNarrativeBot::AdvancedUserNarrative do describe 'when reply contains the skip trigger' do it 'should create the right reply' do - post.update!(raw: "@#{discobot_user.username} #{skip_trigger}") + post.update!(raw: "@#{discobot_user.username} #{skip_trigger.upcase}") described_class.any_instance.expects(:enqueue_timeout_job).with(user) DiscourseNarrativeBot::TrackSelector.new(:reply, user, post_id: post.id).select @@ -225,7 +225,7 @@ RSpec.describe DiscourseNarrativeBot::AdvancedUserNarrative do describe 'when reply contains the skip trigger' do it 'should create the right reply' do - post.update!(raw: skip_trigger) + post.update!(raw: skip_trigger.upcase) described_class.any_instance.expects(:enqueue_timeout_job).with(user) DiscourseNarrativeBot::TrackSelector.new(:reply, user, post_id: post.id).select diff --git a/plugins/discourse-narrative-bot/spec/discourse_narrative_bot/new_user_narrative_spec.rb b/plugins/discourse-narrative-bot/spec/discourse_narrative_bot/new_user_narrative_spec.rb index f85c05b070f..b3b19a70153 100644 --- a/plugins/discourse-narrative-bot/spec/discourse_narrative_bot/new_user_narrative_spec.rb +++ b/plugins/discourse-narrative-bot/spec/discourse_narrative_bot/new_user_narrative_spec.rb @@ -213,7 +213,7 @@ describe DiscourseNarrativeBot::NewUserNarrative do describe 'when reply contains the skip trigger' do it 'should create the right reply' do - post.update!(raw: "@#{discobot_user.username} #{skip_trigger}") + post.update!(raw: "@#{discobot_user.username} #{skip_trigger.upcase}") described_class.any_instance.expects(:enqueue_timeout_job).with(user) DiscourseNarrativeBot::TrackSelector.new(:reply, user, post_id: post.id).select @@ -286,7 +286,7 @@ describe DiscourseNarrativeBot::NewUserNarrative do describe 'when user replies to the topic' do describe 'when reply contains the skip trigger' do it 'should create the right reply' do - post.update!(raw: skip_trigger) + post.update!(raw: skip_trigger.upcase) described_class.any_instance.expects(:enqueue_timeout_job).with(user) DiscourseNarrativeBot::TrackSelector.new(:reply, user, post_id: post.id).select