Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: disambiguate system spec find to prevent flakyness (#22698)

This commit is contained in:
Roman Rizzi 2023-07-19 15:57:23 -03:00 committed by GitHub
parent 90f395a118
commit 9650bf9d08
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/assets/javascripts/discourse/app/widgets/summary-box.js
View File

@ -24,7 +24,7 @@ createWidget("summary-skeleton", {
h("span", {}, [ h("span", {}, [
iconNode("magic", { class: "rotate-center" }), iconNode("magic", { class: "rotate-center" }),
h( h(
"p.placeholder-generating-summary-text", "div.placeholder-generating-summary-text",
{}, {},
I18n.t("summary.in_progress") I18n.t("summary.in_progress")
), ),
@ -51,7 +51,11 @@ export default createWidget("summary-box", {
const html = []; const html = [];
if (attrs.summary) { if (attrs.summary) {
html.push(new RawHtml({ html: `<div>${attrs.summary}</div>` })); html.push(
new RawHtml({
html: `<div class="generated-summary">${attrs.summary}</div>`,
})
);
html.push( html.push(
h("div.summarized-on", {}, [ h("div.summarized-on", {}, [
new RenderGlimmer( new RenderGlimmer(

2
spec/system/topic_summarization_spec.rb
View File

@ -25,7 +25,7 @@ RSpec.describe "Topic summarization", type: :system, js: true do
find(".topic-strategy-summarization").click find(".topic-strategy-summarization").click
summary = find(".summary-box p").text summary = find(".summary-box .generated-summary p").text
expect(summary).to eq(expected_summary) expect(summary).to eq(expected_summary)
end end