Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Use `RenderGlimmer` for experimental user menu (#17597) 

`RenderGlimmer` means we can now drop the classic-component wrapper. The old `didInsertElement` hook is reimplemented via the `did-insert` modifier.
This commit is contained in:
David Taylor 2022-07-21 19:38:07 +01:00 committed by GitHub
parent 6c5efb61c9
commit 98bacbd2c6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 13 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
app/assets/javascripts/discourse/app/components/user-menu-wrapper.js
View File

@ -1,12 +0,0 @@
import Component from "@ember/component";
import layout from "discourse/templates/components/user-menu-wrapper";
export default Component.extend({
layout,
tagName: "",
didInsertElement() {
this._super(...arguments);
this.appEvents.trigger("user-menu:rendered");
},
});

2
app/assets/javascripts/discourse/app/components/user-menu/menu.hbs
View File

@ -1,4 +1,4 @@
<div class="user-menu revamped menu-panel drop-down" data-max-width="320"> <div class="user-menu revamped menu-panel drop-down" data-max-width="320" {{did-insert this.triggerRenderedAppEvent}}>
<div class="panel-body"> <div class="panel-body">
<div class="panel-body-contents"> <div class="panel-body-contents">
<div <div

5
app/assets/javascripts/discourse/app/components/user-menu/menu.js
View File

@ -52,4 +52,9 @@ export default class UserMenu extends GlimmerComponent {
this.currentPanelComponent = tab.panelComponent; this.currentPanelComponent = tab.panelComponent;
} }
} }
@action
triggerRenderedAppEvent() {
this.appEvents.trigger("user-menu:rendered");
}
} }

1
app/assets/javascripts/discourse/app/templates/components/user-menu-wrapper.hbs
View File

@ -1 +0,0 @@
<UserMenu::Menu/>

11
app/assets/javascripts/discourse/app/widgets/header.js
View File

@ -11,7 +11,8 @@ import { schedule } from "@ember/runloop";
import { scrollTop } from "discourse/mixins/scroll-top"; import { scrollTop } from "discourse/mixins/scroll-top";
import { wantsNewWindow } from "discourse/lib/intercept-click"; import { wantsNewWindow } from "discourse/lib/intercept-click";
import { logSearchLinkClick } from "discourse/lib/search"; import { logSearchLinkClick } from "discourse/lib/search";
import ComponentConnector from "discourse/widgets/component-connector"; import RenderGlimmer from "discourse/widgets/render-glimmer";
import { hbs } from "ember-cli-htmlbars";
const _extraHeaderIcons = []; const _extraHeaderIcons = [];
@ -338,9 +339,11 @@ createWidget("revamped-user-menu-wrapper", {
html() { html() {
return [ return [
new ComponentConnector(this, "user-menu-wrapper", {}, [], { new RenderGlimmer(
applyStyle: false, this,
}), "div.widget-component-connector",
hbs`<UserMenu::Menu />`
),
]; ];
}, },