Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Warn when trying to track user status for user models without ID (#21205) 

User status updates come from the server in a map where keys are user IDs. 
If user.trackStatus() is called for a user model without an ID, the model 
cannot identify its status updates and silently misses them. It's quite hard to 
notice that a user rendered in the UI doesn't receive live status updates. 
Also, it's not immediately obvious what's the reason of the problem. 
A warning will be very helpful here.
This commit is contained in:
Andrei Prigorshnev 2023-04-26 17:05:47 +04:00 committed by GitHub
parent 22991bba44
commit 9932f144c2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/assets/javascripts/discourse/app/models/user.js
View File

@ -1401,6 +1401,13 @@ User.reopen(Evented, {
// always call stopTrackingStatus() when done with a user // always call stopTrackingStatus() when done with a user
trackStatus() { trackStatus() {
if (!this.id) {
// eslint-disable-next-line no-console
console.warn(
"It's impossible to track user status on a user model that doesn't have id. This user model won't be receiving live user status updates."
);
}
if (this._subscribersCount === 0) { if (this._subscribersCount === 0) {
this.addObserver("status", this, "_statusChanged"); this.addObserver("status", this, "_statusChanged");