FIX: trim trailing slash from topic links

This commit is contained in:
Arpit Jalan 2019-01-02 18:01:50 +05:30
parent 30a1d29a7e
commit 993f847a2c
2 changed files with 2 additions and 2 deletions

View File

@ -205,7 +205,7 @@ SQL
reflected_post = Post.find_by(topic_id: topic_id, post_number: post_number.to_i)
end
url = url[0...TopicLink.max_url_length]
url = url[0...TopicLink.max_url_length]&.chomp("/")
return nil if parsed && parsed.host && parsed.host.length > TopicLink.max_domain_length
unless TopicLink.exists?(topic_id: post.topic_id, post_id: post.id, url: url)

View File

@ -41,7 +41,7 @@ describe TopicLink do
it 'works' do
expect(topic.topic_links.pluck(:url)).to contain_exactly(
"http://a.com/",
"http://a.com",
"https://b.com/b",
"//b.com/#{'a' * 500}"[0...TopicLink.max_url_length]
)