FIX: prevents discourse header to go under ipad navigation (#25542)

We had two issues which were present for a long time I think:
- one that impacts both core discourse and chat. We were not setting top on the header when `footer-nav-ipad` was present, meaning that you could make it scroll under if you try to scroll up by putting your finger on the discourse header
- one that impacted only chat. It's also present in core, but in core it's not a probem because we don't have a fixed height div. The body height was higher than the screen which would cause a second scrollbar to appear and would slightly break layout, if you scroll on this scrollbar (body).
This commit is contained in:
Joffrey JAFFEUX 2024-02-02 15:24:18 +01:00 committed by GitHub
parent d7cd09d4ab
commit 9961163e82
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 0 deletions

View File

@ -2,6 +2,10 @@
@include sticky; @include sticky;
top: 0; top: 0;
z-index: z("header"); z-index: z("header");
.footer-nav-ipad & {
top: var(--footer-nav-height, 0px);
}
} }
.d-header { .d-header {

View File

@ -249,6 +249,10 @@ html.has-full-page-chat {
height: 100%; height: 100%;
width: 100%; width: 100%;
&.footer-nav-ipad {
height: calc(100% - var(--footer-nav-height, 0px));
}
body { body {
height: 100%; height: 100%;
width: 100%; width: 100%;