Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: escape youtube title when constructing onebox preview html (#16999)

This commit is contained in:
Mayfield 2022-06-08 01:42:37 -04:00 committed by GitHub
parent 82ac698d4f
commit 99b0578b4c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/onebox/engine/youtube_onebox.rb
View File

@ -42,7 +42,7 @@ module Onebox
result = parse_embed_response result = parse_embed_response
result ||= get_opengraph.data result ||= get_opengraph.data
"<img src='#{result[:image]}' width='#{WIDTH}' height='#{HEIGHT}' title='#{result[:title]}'>" "<img src='#{result[:image]}' width='#{WIDTH}' height='#{HEIGHT}' title='#{CGI::escapeHTML(result[:title])}'>"
else else
to_html to_html
end end

7
spec/lib/oneboxer_spec.rb
View File

@ -384,7 +384,7 @@ describe Oneboxer do
<<~HTML <<~HTML
<html> <html>
<head> <head>
<meta property="og:title" content="Onebox1"> <meta property="og:title" content="Onebox1 - ceci n'est pas un titre">
<meta property="og:description" content="this is bodycontent"> <meta property="og:description" content="this is bodycontent">
<meta property="og:image" content="https://i.ytimg.com/vi/dQw4w9WgXcQ/maxresdefault.jpg"> <meta property="og:image" content="https://i.ytimg.com/vi/dQw4w9WgXcQ/maxresdefault.jpg">
</head> </head>
@ -416,6 +416,11 @@ describe Oneboxer do
output = Oneboxer.onebox("https://www.youtube.com/watch?v=dQw4w9WgXcQ", invalidate_oneboxes: true) output = Oneboxer.onebox("https://www.youtube.com/watch?v=dQw4w9WgXcQ", invalidate_oneboxes: true)
expect(output).to include("<iframe") # Regular youtube onebox expect(output).to include("<iframe") # Regular youtube onebox
end end
it "appropriately escapes youtube titles" do
preview = Oneboxer.preview("https://www.youtube.com/watch?v=dQw4w9WgXcQ", invalidate_oneboxes: true)
expect(preview).to include("ceci n'est pas un titre")
end
end end
it "allows iframes from generic sites via the allowed_iframes setting" do it "allows iframes from generic sites via the allowed_iframes setting" do