SECURITY: Do not overwrite permissions on the General category (#21389)

Before this fix if you had modified the default general category
settings they would be reset back to the default after a deploy.

lib/seed_data/categories.rb

@@ -92,7 +92,7 @@ module SeedData
           permissions: {
             everyone: :full,
           },
-          force_permissions: true,
+          force_permissions: false,
           sidebar: true,
           default_composer_category: true,
         },

spec/lib/seed_data/categories_spec.rb

@@ -99,6 +99,25 @@ RSpec.describe SeedData::Categories do
       expect(SiteSetting.default_composer_category).to eq(Category.last.id)
     end
 
+    it "does not overwrite permissions on the General category" do
+      create_category("general_category_id")
+      expect(Category.last.name).to eq("General")
+      category = Category.last
+
+      expect(category.category_groups.count).to eq(0)
+
+      category.set_permissions(staff: :full)
+      category.save!
+
+      expect(category.category_groups.count).to eq(1)
+
+      expect { create_category("general_category_id") }.not_to change { CategoryGroup.count }
+
+      category.reload
+      expect(category.category_groups.count).to eq(1)
+      expect(category.category_groups.first).to have_attributes(permissions(:staff, :full))
+    end
+
     it "adds default categories SiteSetting.default_sidebar_categories" do
       create_category("staff_category_id")
       staff_category = Category.last