From 9c8645b9e1389346ad26e52adec22e795d269d90 Mon Sep 17 00:00:00 2001 From: Gerhard Schlager Date: Tue, 13 Jul 2021 17:09:41 +0200 Subject: [PATCH] FIX: Don't downcase "all groups" in dropdown Because this doesn't make sense in languages other than English --- app/assets/javascripts/discourse/tests/acceptance/group-test.js | 2 +- .../javascripts/select-kit/addon/components/group-dropdown.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/discourse/tests/acceptance/group-test.js b/app/assets/javascripts/discourse/tests/acceptance/group-test.js index 93a949fc4f3..7f1dbd5ea10 100644 --- a/app/assets/javascripts/discourse/tests/acceptance/group-test.js +++ b/app/assets/javascripts/discourse/tests/acceptance/group-test.js @@ -62,7 +62,7 @@ acceptance("Group - Anonymous", function (needs) { assert.equal( groupDropdown.rowByIndex(0).name(), - I18n.t("groups.index.all").toLowerCase() + I18n.t("groups.index.all") ); this.siteSettings.enable_group_directory = false; diff --git a/app/assets/javascripts/select-kit/addon/components/group-dropdown.js b/app/assets/javascripts/select-kit/addon/components/group-dropdown.js index 365f8c5ad09..a0a12c1a70a 100644 --- a/app/assets/javascripts/select-kit/addon/components/group-dropdown.js +++ b/app/assets/javascripts/select-kit/addon/components/group-dropdown.js @@ -25,7 +25,7 @@ export default ComboBoxComponent.extend({ const shortcuts = []; if (this.enableGroupDirectory || this.get("currentUser.staff")) { - shortcuts.push(I18n.t("groups.index.all").toLowerCase()); + shortcuts.push(I18n.t("groups.index.all")); } return shortcuts.concat(this.groups);