From 9ffc19ec60b788b9b54fb7415e7ee6fcdd523ec1 Mon Sep 17 00:00:00 2001 From: Jarek Radosz Date: Fri, 22 Apr 2022 10:34:13 +0200 Subject: [PATCH] DEV: Don't leave loadScript tests hanging (#16536) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit …when anything goes wrong. Let it move on instead of waiting for global test timeout. --- app/assets/javascripts/discourse/app/lib/load-script.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/assets/javascripts/discourse/app/lib/load-script.js b/app/assets/javascripts/discourse/app/lib/load-script.js index 38d2710e1f6..8aca0d5f95b 100644 --- a/app/assets/javascripts/discourse/app/lib/load-script.js +++ b/app/assets/javascripts/discourse/app/lib/load-script.js @@ -20,6 +20,11 @@ function loadWithTag(path, cb) { registerWaiter(() => finished); } + // Don't leave it hanging if something goes wrong + s.onerror = function () { + finished = true; + }; + s.onload = s.onreadystatechange = function (_, abort) { finished = true; if (