Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactoring of topic view tracking

This commit is contained in:
Sam 2013-03-25 16:00:11 -07:00
parent c2db546877
commit a177264114
1 changed files with 28 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
app/assets/javascripts/discourse/views/topic_view.js
View File

@ -145,6 +145,7 @@ Discourse.TopicView = Discourse.View.extend(Discourse.Scrolling, {
// Triggered whenever any posts are rendered, debounced to save over calling // Triggered whenever any posts are rendered, debounced to save over calling
postsRendered: Discourse.debounce(function() { postsRendered: Discourse.debounce(function() {
this.set('renderedPosts', $('.topic-post'));
this.updatePosition(false); this.updatePosition(false);
}, 50), }, 50),
@ -166,19 +167,29 @@ Discourse.TopicView = Discourse.View.extend(Discourse.Scrolling, {
} }
}.observes("Discourse.hasFocus"), }.observes("Discourse.hasFocus"),
// Called for every post seen, returns the post number getPost: function($post){
postSeen: function($post) { var post, postView;
var post, postView, _ref;
postView = Ember.View.views[$post.prop('id')]; postView = Ember.View.views[$post.prop('id')];
if (postView) { if (postView) {
post = postView.get('post'); return postView.get('post');
if (post.get('post_number') > (this.get('topic.last_read_post_number') || 0)) { }
this.set('topic.last_read_post_number', post.get('post_number')); return null;
},
// Called for every post seen, returns the post number
postSeen: function($post) {
var post, postNumber, screenTrack;
post = this.getPost($post);
if (post) {
postNumber = post.get('post_number');
if (postNumber > (this.get('topic.last_read_post_number') || 0)) {
this.set('topic.last_read_post_number', postNumber);
} }
if (!post.get('read')) { if (!post.get('read')) {
post.set('read', true); post.set('read', true);
_ref = this.get('screenTrack'); screenTrack = this.get('screenTrack');
if (_ref) { _ref.guessedSeen(post.get('post_number')); } if (screenTrack) { screenTrack.guessedSeen(postNumber); }
} }
return post.get('post_number'); return post.get('post_number');
} }
@ -253,12 +264,7 @@ Discourse.TopicView = Discourse.View.extend(Discourse.Scrolling, {
// Load new posts if there are some // Load new posts if there are some
nextPage: function($post) { nextPage: function($post) {
if (this.get('controller.loading') || this.get('controller.seenBottom')) return; if (this.get('controller.loading') || this.get('controller.seenBottom')) return;
return this.loadMore(this.getPost($post));
var postView = Ember.View.views[$post.prop('id')];
if (!postView) return;
var post = postView.get('post');
return this.loadMore(post);
}, },
postCountChanged: (function() { postCountChanged: (function() {
@ -266,6 +272,7 @@ Discourse.TopicView = Discourse.View.extend(Discourse.Scrolling, {
}).observes('topic.highest_post_number'), }).observes('topic.highest_post_number'),
loadMore: function(post) { loadMore: function(post) {
if (!post) { return; }
if (this.get('controller.loading')) { return; } if (this.get('controller.loading')) { return; }
// Don't load if we know we're at the bottom // Don't load if we know we're at the bottom
@ -367,7 +374,9 @@ Discourse.TopicView = Discourse.View.extend(Discourse.Scrolling, {
title, info, rows, screenTrack, _this, currentPost; title, info, rows, screenTrack, _this, currentPost;
_this = this; _this = this;
rows = $('.topic-post'); rows = this.get('renderedPosts');
if (!rows || rows.length === 0) { return; }
info = Discourse.Eyeline.analyze(rows); info = Discourse.Eyeline.analyze(rows);
// if we have no rows // if we have no rows
@ -393,7 +402,10 @@ Discourse.TopicView = Discourse.View.extend(Discourse.Scrolling, {
currentPost = currentPost || seen; currentPost = currentPost || seen;
}); });
this.nonUrgentPositionUpdate({userActive: userActive, currentPost: currentPost || info.bottom}); this.nonUrgentPositionUpdate({
userActive: userActive,
currentPost: currentPost || this.getPost($(rows[info.bottom])).get('post_number')
});
offset = window.pageYOffset || $('html').scrollTop(); offset = window.pageYOffset || $('html').scrollTop();
firstLoaded = this.get('firstPostLoaded'); firstLoaded = this.get('firstPostLoaded');