Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't use `getAttribute` if we don't need to

This commit is contained in:
Robin Ward 2018-12-20 16:41:04 -05:00
parent 816acc6984
commit a2ae67509d
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
app/assets/javascripts/discourse/lib/lazy-load-images.js.es6
View File

@ -12,17 +12,11 @@ function hide(image) {
image.classList.add("d-lazyload");
image.classList.add("d-lazyload-hidden");
imageSources.set(image, {
src: image.getAttribute("src"),
srcSet: image.getAttribute("srcset")
});
imageSources.set(image, { src: image.src, srcset: image.srcset });
image.removeAttribute("srcset");
image.setAttribute(
"src",
image.getAttribute("data-small-upload") || LOADING_DATA
);
image.removeAttribute("data-small-upload");
image.src = image.dataset.smallUpload || LOADING_DATA;
delete image.dataset.smallUpload;
}
// Restore an image when onscreen
@ -42,9 +36,7 @@ function show(image) {
};
copyImg.src = sources.src;
if (sources.srcSet) {
copyImg.srcset = sources.srcSet;
}
copyImg.srcset = sources.srcset || copyImg.srcset;
copyImg.style.position = "absolute";
copyImg.style.top = 0;