Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: raise error if search term length is less than required

This commit is contained in:
Vinoth Kannan 2018-12-18 20:06:59 +05:30
parent 341a6bd78a
commit a313b01148
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/controllers/search_controller.rb
View File

@ -9,6 +9,9 @@ class SearchController < ApplicationController
end end
def show def show
@search_term = params.require(:q)
raise Discourse::InvalidParameters.new(:q) if @search_term.length < SiteSetting.min_search_term_length
search_args = { search_args = {
type_filter: 'topic', type_filter: 'topic',
guardian: guardian, guardian: guardian,
@ -29,7 +32,6 @@ class SearchController < ApplicationController
search_args[:ip_address] = request.remote_ip search_args[:ip_address] = request.remote_ip
search_args[:user_id] = current_user.id if current_user.present? search_args[:user_id] = current_user.id if current_user.present?
@search_term = params[:q]
search = Search.new(@search_term, search_args) search = Search.new(@search_term, search_args)
result = search.execute result = search.execute

5
spec/requests/search_controller_spec.rb
View File

@ -127,6 +127,11 @@ describe SearchController do
end end
context "#show" do context "#show" do
it "raises an error when the search term length is less than required" do
get "/search.json", params: { q: 'ba' }
expect(response.status).to eq(400)
end
it "logs the search term" do it "logs the search term" do
SiteSetting.log_search_queries = true SiteSetting.log_search_queries = true
get "/search.json", params: { q: 'bantha' } get "/search.json", params: { q: 'bantha' }