Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Avoid site-header error when rendering fails (#22993) 

When Ember rendering fails for some reason, `this.header` will be undefined. This causes site-header to raise an error, which often gets printed to the console more obviously than the actual root cause.

This commit makes site-header fail more gracefully in this situation, to avoid it being a red-herring during development/debugging.
This commit is contained in:
David Taylor 2023-08-07 17:03:13 +01:00 committed by GitHub
parent c996b7fe4b
commit a38830c009
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/app/components/site-header.js
View File

@ -486,7 +486,7 @@ export default SiteHeaderComponent.extend({
this._resizeObserver = new ResizeObserver((entries) => {
for (let entry of entries) {
if (entry.contentRect) {
const headerTop = this.header.offsetTop;
const headerTop = this.header?.offsetTop;
document.documentElement.style.setProperty(
"--header-top",
`${headerTop}px`