From a3fde50b62471f256199f2974123d34b85ed3167 Mon Sep 17 00:00:00 2001 From: Penar Musaraj Date: Wed, 13 Oct 2021 11:19:38 -0400 Subject: [PATCH] A11Y: Don't output aria label identical to title (#14586) --- .../app/templates/components/composer-toggles.hbs | 3 --- .../discourse/app/templates/components/d-modal.hbs | 7 ++++++- .../discourse/app/templates/components/share-source.hbs | 1 - .../app/templates/components/topic-timer-info.hbs | 2 -- .../javascripts/discourse/app/templates/composer.hbs | 1 - app/assets/javascripts/discourse/app/templates/topic.hbs | 2 +- 6 files changed, 7 insertions(+), 9 deletions(-) diff --git a/app/assets/javascripts/discourse/app/templates/components/composer-toggles.hbs b/app/assets/javascripts/discourse/app/templates/components/composer-toggles.hbs index 80be3f6f265..4964ed33065 100644 --- a/app/assets/javascripts/discourse/app/templates/components/composer-toggles.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/composer-toggles.hbs @@ -7,7 +7,6 @@ icon="bars" action=toggleToolbar title=toggleToolbarTitle - ariaLabel=toggleToolbarTitle preventFocus=true tabindex=-1 }} @@ -18,7 +17,6 @@ icon=toggleIcon action=toggleComposer title=toggleTitle - ariaLabel=toggleTitle tabindex=-1 }} @@ -28,7 +26,6 @@ icon=fullscreenIcon action=toggleFullscreen title=fullscreenTitle - ariaLabel=fullscreenTitle tabindex=-1 }} {{/unless}} diff --git a/app/assets/javascripts/discourse/app/templates/components/d-modal.hbs b/app/assets/javascripts/discourse/app/templates/components/d-modal.hbs index a0da06d06a7..338af161e5c 100644 --- a/app/assets/javascripts/discourse/app/templates/components/d-modal.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/d-modal.hbs @@ -3,7 +3,12 @@