From a4359d274e20ad9219da5daee4fb5d9ad214e7f1 Mon Sep 17 00:00:00 2001
From: Gabriel Grubba <70247653+Grubba27@users.noreply.github.com>
Date: Wed, 11 Sep 2024 13:57:45 -0300
Subject: [PATCH] DEV: update pull request template with more details of what
 is expected in a PR (#28857)

* DEV: update pull request template with more details of what is expected in a PR

Added information:
- We expected the pr to have a title that is descriptive of the changes
- Good commit messages and prefixes
- If the pull request had UX/UI changes to include screenshots
- If changing flaky tests to include the reason for the change

* Update .github/pull_request_template.md

Co-authored-by: David Taylor <david@taylorhq.com>

---------

Co-authored-by: David Taylor <david@taylorhq.com>
---
 .github/pull_request_template.md | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index 536a268e55d..300d79d29ef 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -1 +1,8 @@
-<!-- NOTE: All pull requests should have tests (rspec in Ruby, qunit in JavaScript). If your code does not include test coverage, please include an explanation of why it was omitted. -->
+<!--
+  NOTE: All pull requests should have:
+    - Tests (rspec in Ruby, qunit in JavaScript). If your code does not include test coverage, please include an explanation of why it was omitted.
+    - A descriptive title and description with context about those changes.
+    - Good commit messages with the correct prefixes see: https://meta.discourse.org/t/discourse-github-commit-prefix-convention/19392
+    - If the pull request had UX/UI changes, please add a screenshot of how it was before and how it is with your changes in mobile and desktop
+    - If changing flakey tests, please add a description in your commit/PR description about the error you were having
+-->
\ No newline at end of file