FIX: Toggling overridden settings broke in #21572 (#22831)

app/assets/javascripts/admin/addon/controllers/admin-site-settings.js

@@ -11,7 +11,7 @@ import { inject as service } from "@ember/service";
 export default class AdminSiteSettingsController extends Controller {
   @service router;
 
-  filter = null;
+  filter = "";
 
   @alias("model") allSiteSettings;
 

app/assets/javascripts/admin/addon/templates/site-settings.hbs

@@ -1,5 +1,4 @@
 <div class="admin-controls">
-
   <div class="controls">
     <div class="inline-form">
       <DButton
@@ -21,9 +20,14 @@
       />
     </div>
   </div>
+
   <div class="search controls">
     <label>
-      <Input @type="checkbox" @checked={{this.onlyOverridden}} />
+      <Input
+        @type="checkbox"
+        @checked={{this.onlyOverridden}}
+        class="toggle-overridden"
+      />
       {{i18n "admin.settings.show_overriden"}}
     </label>
   </div>

app/assets/javascripts/discourse/tests/acceptance/admin-site-settings-test.js

@@ -128,6 +128,14 @@ acceptance("Admin - Site Settings", function (needs) {
     assert.strictEqual(count(".row.setting"), 1);
   });
 
+  test("filtering overridden settings", async function (assert) {
+    await visit("/admin/site_settings");
+    assert.dom(".row.setting").exists({ count: 4 });
+
+    await click(".toggle-overridden");
+    assert.dom(".row.setting").exists({ count: 2 });
+  });
+
   test("filter settings by plugin name", async function (assert) {
     await visit("/admin/site_settings");