discourse/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-09 14:34:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

FIX: prevents &hellip from being displayed in title attribute

Browse Source
This commit is contained in:
Joffrey JAFFEUX 2018-05-23 19:04:26 +02:00 committed by GitHub
parent 7232a6e5a9
commit a45d8a69f9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app/assets/javascripts/select-kit/components/select-kit/select-kit-header.js.es6
View File

@ -9,7 +9,7 @@ export default Ember.Component.extend({
"tabindex", "tabindex",
"ariaLabel:aria-label", "ariaLabel:aria-label",
"ariaHasPopup:aria-haspopup", "ariaHasPopup:aria-haspopup",
"title", "sanitizedTitle:title",
"value:data-value", "value:data-value",
"name:data-name", "name:data-name",
], ],
@ -18,7 +18,7 @@ export default Ember.Component.extend({
ariaHasPopup: true, ariaHasPopup: true,
ariaLabel: Ember.computed.or("computedContent.ariaLabel", "title"), ariaLabel: Ember.computed.or("computedContent.ariaLabel", "sanitizedTitle"),
@computed("computedContent.title", "name") @computed("computedContent.title", "name")
title(computedContentTitle, name) { title(computedContentTitle, name) {
@ -28,6 +28,13 @@ export default Ember.Component.extend({
return null; return null;
}, },
// this might need a more advanced solution
// but atm it's the only case we have to handle
@computed("title")
sanitizedTitle(title) {
return String(title).replace("…", "");
},
label: Ember.computed.or("computedContent.label", "title", "name"), label: Ember.computed.or("computedContent.label", "title", "name"),
name: Ember.computed.alias("computedContent.name"), name: Ember.computed.alias("computedContent.name"),