Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

UX: Remove bookmarks link from community section (#17608) 

Product decision to drop it from Sidebar at this moment.
This commit is contained in:
Alan Guo Xiang Tan 2022-07-22 15:55:13 +08:00 committed by GitHub
parent 4594ce2723
commit a626b99a50
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 0 additions and 54 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/app/components/sidebar/community-section.js
View File

@ -5,7 +5,6 @@ import PermissionType from "discourse/models/permission-type";
import { customSectionLinks } from "discourse/lib/sidebar/custom-community-section-links";
import EverythingSectionLink from "discourse/lib/sidebar/community-section/everything-section-link";
import TrackedSectionLink from "discourse/lib/sidebar/community-section/tracked-section-link";
import BookmarkedSectionLink from "discourse/lib/sidebar/community-section/bookmarked-section-link";
import MyPostsSectionLink from "discourse/lib/sidebar/community-section/my-posts-section-link";
import { action } from "@ember/object";
@ -14,7 +13,6 @@ import { next } from "@ember/runloop";
const DEFAULT_SECTION_LINKS = [
EverythingSectionLink,
TrackedSectionLink,
BookmarkedSectionLink,
MyPostsSectionLink,
];

25
app/assets/javascripts/discourse/app/lib/sidebar/community-section/bookmarked-section-link.js
View File

@ -1,25 +0,0 @@
import I18n from "I18n";
import BaseSectionLink from "discourse/lib/sidebar/community-section/base-section-link";
export default class BookmarkedSectionLink extends BaseSectionLink {
get name() {
return "bookmarked";
}
get route() {
return "userActivity.bookmarks";
}
get model() {
return this.currentUser;
}
get title() {
return I18n.t("sidebar.sections.community.links.bookmarked.title");
}
get text() {
return I18n.t("sidebar.sections.community.links.bookmarked.content");
}
}

24
app/assets/javascripts/discourse/tests/acceptance/sidebar-community-section-test.js
View File

@ -158,30 +158,6 @@ acceptance("Sidebar - Community Section", function (needs) {
);
});
test("clicking on bookmarked link", async function (assert) {
await visit("/t/280");
await click(".sidebar-section-community .sidebar-section-link-bookmarked");
assert.strictEqual(
currentURL(),
`/u/${loggedInUser().username}/activity/bookmarks`,
"it should transition to the bookmarked url"
);
assert.strictEqual(
count(".sidebar-section-community .sidebar-section-link.active"),
1,
"only one link is marked as active"
);
assert.ok(
exists(
".sidebar-section-community .sidebar-section-link-bookmarked.active"
),
"the bookmarked link is marked as active"
);
});
test("clicking on my posts link", async function (assert) {
await visit("/t/280");
await click(".sidebar-section-community .sidebar-section-link-my-posts");

3
config/locales/client.en.yml
View File

@ -4107,9 +4107,6 @@ en:
tracked:
content: "Tracked"
title: "All tracked topics"
bookmarked:
content: "Bookmarked"
title: "All bookmarked topics"
my_posts:
content: "My Posts"
title: "My posts"