DEV: Improve localizability for a few labels (#26178)

Using separate prefix + date elements makes it harder to translate in
some languages. This moves a few dates inside i18n strings.

app/assets/javascripts/discourse/app/components/user-preferences/user-passkeys.gjs

@@ -3,6 +3,7 @@ import { fn } from "@ember/helper";
 import { action } from "@ember/object";
 import { schedule } from "@ember/runloop";
 import { service } from "@ember/service";
+import { htmlSafe } from "@ember/template";
 import DButton from "discourse/components/d-button";
 import ConfirmSession from "discourse/components/dialog-messages/confirm-session";
 import PasskeyOptionsDropdown from "discourse/components/user-preferences/passkey-options-dropdown";
@@ -14,6 +15,7 @@ import {
   stringToBuffer,
   WebauthnAbortHandler,
 } from "discourse/lib/webauthn";
+import i18n from "discourse-common/helpers/i18n";
 import I18n from "discourse-i18n";
 
 export default class UserPasskeys extends Component {
@@ -22,12 +24,6 @@ export default class UserPasskeys extends Component {
   @service capabilities;
   @service router;
 
-  instructions = I18n.t("user.passkeys.short_description");
-  title = I18n.t("user.passkeys.title");
-  addedPrefix = I18n.t("user.passkeys.added_prefix");
-  lastUsedPrefix = I18n.t("user.passkeys.last_used_prefix");
-  neverUsed = I18n.t("user.passkeys.never_used");
-
   get showActions() {
     return (
       this.currentUser.id === this.args.model.id &&
@@ -182,10 +178,10 @@ export default class UserPasskeys extends Component {
   <template>
     <div class="control-group pref-passkeys">
       <label class="control-label">
-        {{this.title}}
+        {{i18n "user.passkeys.title"}}
       </label>
       <div class="instructions">
-        {{this.instructions}}
+        {{i18n "user.passkeys.short_description"}}
       </div>
 
       <div class="pref-passkeys__rows">
@@ -194,27 +190,27 @@ export default class UserPasskeys extends Component {
             <div class="passkey-left">
               <div class="row-passkey__name">{{passkey.name}}</div>
               <div class="row-passkey__created-date">
-                <span class="prefix">
-                  {{this.addedPrefix}}
-                </span>
-                {{formatDate
-                  passkey.created_at
-                  format="medium"
-                  leaveAgo="true"
+                {{htmlSafe
+                  (i18n
+                    "user.passkeys.added_date"
+                    date=(formatDate
+                      passkey.created_at format="medium" leaveAgo="true"
+                    )
+                  )
                 }}
               </div>
               <div class="row-passkey__used-date">
                 {{#if passkey.last_used}}
-                  <span class="prefix">
-                    {{this.lastUsedPrefix}}
-                  </span>
-                  {{formatDate
-                    passkey.last_used
-                    format="medium"
-                    leaveAgo="true"
+                  {{htmlSafe
+                    (i18n
+                      "user.passkeys.last_used_date"
+                      date=(formatDate
+                        passkey.last_used format="medium" leaveAgo="true"
+                      )
+                    )
                   }}
                 {{else}}
-                  {{this.neverUsed}}
+                  {{i18n "user.passkeys.never_used"}}
                 {{/if}}
               </div>
             </div>

config/locales/client.en.yml

@@ -1537,8 +1537,8 @@ en:
         save: "Save"
         title: "Passkeys"
         short_description: "Passkeys are password replacements that validate your identity biometrically (e.g. touch, faceID) or via a device PIN/password."
-        added_prefix: "Added"
-        last_used_prefix: "Last Used"
+        added_date: "Added %{date}"
+        last_used_date: "Last Used %{date}"
         never_used: "Never Used"
         not_allowed_error: "The passkey registration process either timed out, was cancelled or is not allowed."
         already_added_error: "You have already registered this passkey. You don’t have to register it again."