From a89767913d4183ed43aabb9e2029f4caa157e48c Mon Sep 17 00:00:00 2001
From: Kelv <kelv@discourse.org>
Date: Fri, 25 Oct 2024 15:13:06 +0800
Subject: [PATCH] resolve Rails/ReversibleMigrationMethodDefinition errors
 (#29412)

---
 db/migrate/20120427154330_create_vestal_versions.rb           | 4 ++--
 db/migrate/20120924182000_add_hstore_extension.rb             | 4 ++--
 db/migrate/20130127213646_remove_trust_levels.rb              | 4 ++++
 .../20131014203951_backfill_post_upload_reverse_index.rb      | 4 ++++
 db/migrate/20131210181901_migrate_word_counts.rb              | 4 ++++
 db/migrate/20140929204155_migrate_tos_setting.rb              | 4 ++++
 db/migrate/20141014191645_fix_tos_name.rb                     | 4 ++++
 db/migrate/20150709021818_add_like_count_to_post_menu.rb      | 4 ++++
 db/migrate/20150728210202_migrate_old_moderator_posts.rb      | 4 ++++
 db/migrate/20150729150523_migrate_auto_close_posts.rb         | 4 ++++
 db/migrate/20150731225331_migrate_old_moved_posts.rb          | 4 ++++
 db/migrate/20150822141540_fix_migrated_hosts.rb               | 4 ++++
 db/migrate/20160407160756_remove_user_firsts.rb               | 4 ++++
 .../20160627104436_use_https_name_change_in_site_settings.rb  | 4 ++++
 db/migrate/20161202034856_add_uploads_to_categories.rb        | 4 ++++
 db/migrate/20180521190040_allow_null_ip_topic_link_click.rb   | 4 ++++
 db/migrate/20190123171817_drop_queued_posts.rb                | 4 ++++
 db/migrate/20190402142223_disable_invite_only_sso.rb          | 4 ++++
 db/migrate/20190503180839_remove_like_count_from_post_menu.rb | 4 ++++
 db/migrate/20190508141824_drop_claimed_by_id.rb               | 4 ++++
 db/migrate/20190908234054_migrate_post_edit_time_limit.rb     | 4 ++++
 db/migrate/20191025005204_amend_oauth2_user_info_index.rb     | 4 ++++
 .../20200429095035_migrate_image_url_to_image_upload_id.rb    | 4 ++++
 .../20210127140730_undo_add_processed_to_notifications.rb     | 4 ++++
 db/migrate/20230224225129_backfill_svg_sprites.rb             | 4 ++++
 ...42434_backfill_auto_bump_cooldown_days_category_setting.rb | 4 ++++
 ...116_swap_field_type_with_field_type_enum_on_user_fields.rb | 2 ++
 ...40912210450_delete_anonymous_users_from_directory_items.rb | 3 +++
 .../20241023041126_clear_duplicate_admin_notices.rb           | 3 +++
 29 files changed, 108 insertions(+), 4 deletions(-)

diff --git a/db/migrate/20120427154330_create_vestal_versions.rb b/db/migrate/20120427154330_create_vestal_versions.rb
index ae88fd24116..dc4dcc710bf 100644
--- a/db/migrate/20120427154330_create_vestal_versions.rb
+++ b/db/migrate/20120427154330_create_vestal_versions.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class CreateVestalVersions < ActiveRecord::Migration[4.2]
-  def self.up
+  def up
     create_table :versions do |t|
       t.belongs_to :versioned, polymorphic: true
       t.belongs_to :user, polymorphic: true
@@ -24,7 +24,7 @@ class CreateVestalVersions < ActiveRecord::Migration[4.2]
     end
   end
 
-  def self.down
+  def down
     drop_table :versions
   end
 end
diff --git a/db/migrate/20120924182000_add_hstore_extension.rb b/db/migrate/20120924182000_add_hstore_extension.rb
index 0b9847f18db..071dad46f29 100644
--- a/db/migrate/20120924182000_add_hstore_extension.rb
+++ b/db/migrate/20120924182000_add_hstore_extension.rb
@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
 class AddHstoreExtension < ActiveRecord::Migration[4.2]
-  def self.up
+  def up
     execute "CREATE EXTENSION IF NOT EXISTS hstore"
   end
 
-  def self.down
+  def down
     execute "DROP EXTENSION hstore"
   end
 end
diff --git a/db/migrate/20130127213646_remove_trust_levels.rb b/db/migrate/20130127213646_remove_trust_levels.rb
index 0e7fea2b71f..3ef7af59d5d 100644
--- a/db/migrate/20130127213646_remove_trust_levels.rb
+++ b/db/migrate/20130127213646_remove_trust_levels.rb
@@ -11,4 +11,8 @@ class RemoveTrustLevels < ActiveRecord::Migration[4.2]
     remove_column :users, :moderator
     add_column :users, :flag_level, :integer, null: false, default: 0
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20131014203951_backfill_post_upload_reverse_index.rb b/db/migrate/20131014203951_backfill_post_upload_reverse_index.rb
index ed05ce25ac0..b44dc7252b3 100644
--- a/db/migrate/20131014203951_backfill_post_upload_reverse_index.rb
+++ b/db/migrate/20131014203951_backfill_post_upload_reverse_index.rb
@@ -17,6 +17,10 @@ class BackfillPostUploadReverseIndex < ActiveRecord::Migration[4.2]
       end
   end
 
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
+
   def add_to_reverse_index(url, post_id)
     # make sure we have a url to insert
     return if url.blank?
diff --git a/db/migrate/20131210181901_migrate_word_counts.rb b/db/migrate/20131210181901_migrate_word_counts.rb
index 861547925c5..7f20c255b06 100644
--- a/db/migrate/20131210181901_migrate_word_counts.rb
+++ b/db/migrate/20131210181901_migrate_word_counts.rb
@@ -34,4 +34,8 @@ class MigrateWordCounts < ActiveRecord::Migration[4.2]
         execute("SELECT id FROM topics WHERE word_count IS NULL LIMIT 500").map { |r| r["id"].to_i }
     end
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20140929204155_migrate_tos_setting.rb b/db/migrate/20140929204155_migrate_tos_setting.rb
index 7085399ab99..d43679de7ac 100644
--- a/db/migrate/20140929204155_migrate_tos_setting.rb
+++ b/db/migrate/20140929204155_migrate_tos_setting.rb
@@ -15,4 +15,8 @@ class MigrateTosSetting < ActiveRecord::Migration[4.2]
       )
     end
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20141014191645_fix_tos_name.rb b/db/migrate/20141014191645_fix_tos_name.rb
index b9e38f830da..df158d842ac 100644
--- a/db/migrate/20141014191645_fix_tos_name.rb
+++ b/db/migrate/20141014191645_fix_tos_name.rb
@@ -8,4 +8,8 @@ class FixTosName < ActiveRecord::Migration[4.2]
       WHERE name = 'I have read and accept the <a href="/tos" target="_blank">Terms of Service</a>.'
     SQL
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20150709021818_add_like_count_to_post_menu.rb b/db/migrate/20150709021818_add_like_count_to_post_menu.rb
index d953cc94384..3ba823687ea 100644
--- a/db/migrate/20150709021818_add_like_count_to_post_menu.rb
+++ b/db/migrate/20150709021818_add_like_count_to_post_menu.rb
@@ -9,4 +9,8 @@ WHERE name = 'post_menu'
 AND value NOT LIKE '%like-count%'
 SQL
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20150728210202_migrate_old_moderator_posts.rb b/db/migrate/20150728210202_migrate_old_moderator_posts.rb
index 37f58715274..71799baed7b 100644
--- a/db/migrate/20150728210202_migrate_old_moderator_posts.rb
+++ b/db/migrate/20150728210202_migrate_old_moderator_posts.rb
@@ -21,4 +21,8 @@ class MigrateOldModeratorPosts < ActiveRecord::Migration[4.2]
     migrate_key("pinned_globally.disabled")
     Rails.application.config.i18n.raise_on_missing_translations = true
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20150729150523_migrate_auto_close_posts.rb b/db/migrate/20150729150523_migrate_auto_close_posts.rb
index 572467693e5..0bd84c05604 100644
--- a/db/migrate/20150729150523_migrate_auto_close_posts.rb
+++ b/db/migrate/20150729150523_migrate_auto_close_posts.rb
@@ -21,4 +21,8 @@ class MigrateAutoClosePosts < ActiveRecord::Migration[4.2]
       SQL
     end
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20150731225331_migrate_old_moved_posts.rb b/db/migrate/20150731225331_migrate_old_moved_posts.rb
index ef085091efc..d58740ec0d5 100644
--- a/db/migrate/20150731225331_migrate_old_moved_posts.rb
+++ b/db/migrate/20150731225331_migrate_old_moved_posts.rb
@@ -5,4 +5,8 @@ class MigrateOldMovedPosts < ActiveRecord::Migration[4.2]
     execute "UPDATE posts SET post_type = 3, action_code = 'split_topic' WHERE post_type = 2 AND raw ~* '^I moved [a\\d]+ posts? to a new topic:'"
     execute "UPDATE posts SET post_type = 3, action_code = 'split_topic' WHERE post_type = 2 AND raw ~* '^I moved [a\\d]+ posts? to an existing topic:'"
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20150822141540_fix_migrated_hosts.rb b/db/migrate/20150822141540_fix_migrated_hosts.rb
index 77767e5215b..91a6659161f 100644
--- a/db/migrate/20150822141540_fix_migrated_hosts.rb
+++ b/db/migrate/20150822141540_fix_migrated_hosts.rb
@@ -4,4 +4,8 @@ class FixMigratedHosts < ActiveRecord::Migration[4.2]
   def up
     execute "UPDATE embeddable_hosts SET host = regexp_replace(host, '^https?:\/\/', '', 'i')"
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20160407160756_remove_user_firsts.rb b/db/migrate/20160407160756_remove_user_firsts.rb
index e09b77250c5..07905e4be4f 100644
--- a/db/migrate/20160407160756_remove_user_firsts.rb
+++ b/db/migrate/20160407160756_remove_user_firsts.rb
@@ -7,4 +7,8 @@ class RemoveUserFirsts < ActiveRecord::Migration[4.2]
     # continues with other migrations if we can't delete that table
     nil
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20160627104436_use_https_name_change_in_site_settings.rb b/db/migrate/20160627104436_use_https_name_change_in_site_settings.rb
index d3f00e96313..34c62409220 100644
--- a/db/migrate/20160627104436_use_https_name_change_in_site_settings.rb
+++ b/db/migrate/20160627104436_use_https_name_change_in_site_settings.rb
@@ -4,4 +4,8 @@ class UseHttpsNameChangeInSiteSettings < ActiveRecord::Migration[4.2]
   def up
     execute "UPDATE site_settings SET name = 'force_https' WHERE name = 'use_https'"
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20161202034856_add_uploads_to_categories.rb b/db/migrate/20161202034856_add_uploads_to_categories.rb
index 33fc8563352..1c83474e6db 100644
--- a/db/migrate/20161202034856_add_uploads_to_categories.rb
+++ b/db/migrate/20161202034856_add_uploads_to_categories.rb
@@ -21,4 +21,8 @@ class AddUploadsToCategories < ActiveRecord::Migration[4.2]
     WHERE c1.id = c2.id
     SQL
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20180521190040_allow_null_ip_topic_link_click.rb b/db/migrate/20180521190040_allow_null_ip_topic_link_click.rb
index 69a37049685..584c5c5fe7c 100644
--- a/db/migrate/20180521190040_allow_null_ip_topic_link_click.rb
+++ b/db/migrate/20180521190040_allow_null_ip_topic_link_click.rb
@@ -9,4 +9,8 @@ class AllowNullIpTopicLinkClick < ActiveRecord::Migration[5.1]
       Migration::SafeMigrate.enable!
     end
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20190123171817_drop_queued_posts.rb b/db/migrate/20190123171817_drop_queued_posts.rb
index 704b98428e2..4c700c2e01b 100644
--- a/db/migrate/20190123171817_drop_queued_posts.rb
+++ b/db/migrate/20190123171817_drop_queued_posts.rb
@@ -4,4 +4,8 @@ class DropQueuedPosts < ActiveRecord::Migration[5.2]
   def up
     drop_table :queued_posts
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20190402142223_disable_invite_only_sso.rb b/db/migrate/20190402142223_disable_invite_only_sso.rb
index a33e200e16e..919fe1bd676 100644
--- a/db/migrate/20190402142223_disable_invite_only_sso.rb
+++ b/db/migrate/20190402142223_disable_invite_only_sso.rb
@@ -8,4 +8,8 @@ class DisableInviteOnlySso < ActiveRecord::Migration[5.2]
         AND EXISTS(SELECT 1 FROM site_settings WHERE name = 'enable_sso' AND value = 't')
     SQL
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20190503180839_remove_like_count_from_post_menu.rb b/db/migrate/20190503180839_remove_like_count_from_post_menu.rb
index 454d22ac589..7e49f5fd2ed 100644
--- a/db/migrate/20190503180839_remove_like_count_from_post_menu.rb
+++ b/db/migrate/20190503180839_remove_like_count_from_post_menu.rb
@@ -8,4 +8,8 @@ class RemoveLikeCountFromPostMenu < ActiveRecord::Migration[5.2]
       WHERE name = 'post_menu'
     SQL
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20190508141824_drop_claimed_by_id.rb b/db/migrate/20190508141824_drop_claimed_by_id.rb
index ed9bca6975a..f99d39e7f43 100644
--- a/db/migrate/20190508141824_drop_claimed_by_id.rb
+++ b/db/migrate/20190508141824_drop_claimed_by_id.rb
@@ -4,4 +4,8 @@ class DropClaimedById < ActiveRecord::Migration[5.2]
   def up
     remove_column :reviewables, :claimed_by_id
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20190908234054_migrate_post_edit_time_limit.rb b/db/migrate/20190908234054_migrate_post_edit_time_limit.rb
index cd84b391f9e..55a82dc135d 100644
--- a/db/migrate/20190908234054_migrate_post_edit_time_limit.rb
+++ b/db/migrate/20190908234054_migrate_post_edit_time_limit.rb
@@ -23,4 +23,8 @@ class MigratePostEditTimeLimit < ActiveRecord::Migration[5.2]
     DO NOTHING
     SQL
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20191025005204_amend_oauth2_user_info_index.rb b/db/migrate/20191025005204_amend_oauth2_user_info_index.rb
index e9e18913130..3df57b3a6f1 100644
--- a/db/migrate/20191025005204_amend_oauth2_user_info_index.rb
+++ b/db/migrate/20191025005204_amend_oauth2_user_info_index.rb
@@ -6,4 +6,8 @@ class AmendOauth2UserInfoIndex < ActiveRecord::Migration[6.0]
     execute "DROP INDEX index_oauth2_user_infos_on_user_id_and_provider"
     add_index :oauth2_user_infos, %i[user_id provider]
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20200429095035_migrate_image_url_to_image_upload_id.rb b/db/migrate/20200429095035_migrate_image_url_to_image_upload_id.rb
index e6d905f5df0..c374d6ef03b 100644
--- a/db/migrate/20200429095035_migrate_image_url_to_image_upload_id.rb
+++ b/db/migrate/20200429095035_migrate_image_url_to_image_upload_id.rb
@@ -98,6 +98,10 @@ class MigrateImageUrlToImageUploadId < ActiveRecord::Migration[6.0]
     drop_temporary_table!
   end
 
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
+
   def drop_temporary_table!
     Migration::SafeMigrate.disable!
     execute <<~SQL
diff --git a/db/migrate/20210127140730_undo_add_processed_to_notifications.rb b/db/migrate/20210127140730_undo_add_processed_to_notifications.rb
index 2904760628b..2ce0b7675c0 100644
--- a/db/migrate/20210127140730_undo_add_processed_to_notifications.rb
+++ b/db/migrate/20210127140730_undo_add_processed_to_notifications.rb
@@ -3,4 +3,8 @@ class UndoAddProcessedToNotifications < ActiveRecord::Migration[6.0]
   def up
     execute "ALTER TABLE notifications DROP COLUMN IF EXISTS processed"
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20230224225129_backfill_svg_sprites.rb b/db/migrate/20230224225129_backfill_svg_sprites.rb
index b7b8b04d69e..f5c48366a41 100644
--- a/db/migrate/20230224225129_backfill_svg_sprites.rb
+++ b/db/migrate/20230224225129_backfill_svg_sprites.rb
@@ -6,4 +6,8 @@ class BackfillSvgSprites < ActiveRecord::Migration[7.0]
   def up
     ThemeSvgSprite.refetch!
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/migrate/20230308042434_backfill_auto_bump_cooldown_days_category_setting.rb b/db/migrate/20230308042434_backfill_auto_bump_cooldown_days_category_setting.rb
index f37c9117e24..24918dcbf37 100644
--- a/db/migrate/20230308042434_backfill_auto_bump_cooldown_days_category_setting.rb
+++ b/db/migrate/20230308042434_backfill_auto_bump_cooldown_days_category_setting.rb
@@ -23,4 +23,8 @@ class BackfillAutoBumpCooldownDaysCategorySetting < ActiveRecord::Migration[7.0]
           updated_at = NOW();
     SQL
   end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
 end
diff --git a/db/post_migrate/20240612073116_swap_field_type_with_field_type_enum_on_user_fields.rb b/db/post_migrate/20240612073116_swap_field_type_with_field_type_enum_on_user_fields.rb
index 0169bf033e0..19b351e6ed6 100644
--- a/db/post_migrate/20240612073116_swap_field_type_with_field_type_enum_on_user_fields.rb
+++ b/db/post_migrate/20240612073116_swap_field_type_with_field_type_enum_on_user_fields.rb
@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 class SwapFieldTypeWithFieldTypeEnumOnUserFields < ActiveRecord::Migration[7.0]
+  def change
+  end
   # DROPPED_COLUMNS = { user_fields: %i[field_type] }
 
   # def up
diff --git a/db/post_migrate/20240912210450_delete_anonymous_users_from_directory_items.rb b/db/post_migrate/20240912210450_delete_anonymous_users_from_directory_items.rb
index bfebef1ba57..1a6261aee96 100644
--- a/db/post_migrate/20240912210450_delete_anonymous_users_from_directory_items.rb
+++ b/db/post_migrate/20240912210450_delete_anonymous_users_from_directory_items.rb
@@ -8,4 +8,7 @@ class DeleteAnonymousUsersFromDirectoryItems < ActiveRecord::Migration[7.1]
       WHERE directory_items.user_id = anonymous_users.user_id
     SQL
   end
+
+  def down
+  end
 end
diff --git a/db/post_migrate/20241023041126_clear_duplicate_admin_notices.rb b/db/post_migrate/20241023041126_clear_duplicate_admin_notices.rb
index 670259d232f..001980054a9 100644
--- a/db/post_migrate/20241023041126_clear_duplicate_admin_notices.rb
+++ b/db/post_migrate/20241023041126_clear_duplicate_admin_notices.rb
@@ -8,4 +8,7 @@ class ClearDuplicateAdminNotices < ActiveRecord::Migration[7.1]
       WHERE subject = #{problem_subject_id}
     SQL
   end
+
+  def down
+  end
 end