Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FEATURE: Block vibration in Firefox Android (#10389) 

Legacy Firefox Android has some quirks around vibration where it:

- asks for permission
- doesn't persist the permission

This makes the default like vibration popup a permission on Firefox
Android <= 68.

This isn't the case (yet?) on their new Firefox which is rolling out
worldwide right now.

I'd say we merge this now and revert in 3 months or so when
https://arewefenixyet.com/ shows a full rollout.
This commit is contained in:
Rafael dos Santos Silva 2020-08-07 15:38:53 -03:00 committed by GitHub
parent 32f6c5c07e
commit a97e36cfda
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/app/pre-initializers/sniff-capabilities.js
View File

@ -46,7 +46,7 @@ export default {
caps.hasContactPicker = caps.hasContactPicker =
"contacts" in navigator && "ContactsManager" in window; "contacts" in navigator && "ContactsManager" in window;
caps.canVibrate = "vibrate" in navigator; caps.canVibrate = "vibrate" in navigator && !caps.isFirefox; // Remove Firefox condition when https://arewefenixyet.com/ lands
} }
// We consider high res a device with 1280 horizontal pixels. High DPI tablets like // We consider high res a device with 1280 horizontal pixels. High DPI tablets like