DEV: Update ESLint to remove I18n global

Also fixes missed imports in core.

app/assets/javascripts/discourse-loader.js

@@ -143,6 +143,7 @@ var define, requirejs;
         guidFor: Ember.guidFor
       },
       I18n: {
+        // eslint-disable-next-line
         default: I18n
       }
     };

app/assets/javascripts/discourse/app/mixins/user-fields-validation.js

@@ -2,6 +2,7 @@ import { isEmpty } from "@ember/utils";
 import EmberObject from "@ember/object";
 import discourseComputed, { on } from "discourse-common/utils/decorators";
 import Mixin from "@ember/object/mixin";
+import I18n from "I18n";
 
 export default Mixin.create({
   @on("init")

app/assets/javascripts/preload-application-data.js

@@ -3,6 +3,7 @@
   const ps = require("discourse/lib/preload-store").default;
   const preloadedDataElement = document.getElementById("data-preloaded");
   const setupData = document.getElementById("data-discourse-setup").dataset;
+  const I18n = require("I18n").default;
 
   if (preloadedDataElement) {
     const preloaded = JSON.parse(preloadedDataElement.dataset.preloaded);

package.json

@@ -45,7 +45,7 @@
     "chrome-launcher": "^0.12.0",
     "chrome-remote-interface": "^0.25",
     "ember-template-lint": "^2.5.2",
-    "eslint-config-discourse": "1.1.1",
+    "eslint-config-discourse": "1.1.2",
     "eslint-plugin-discourse-ember": "0.0.3",
     "lodash-cli": "https://github.com/lodash-archive/lodash-cli.git",
     "pretender": "^1.6",

test/javascripts/acceptance/admin-user-emails-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance } from "helpers/qunit-helpers";
 
 acceptance("Admin - User Emails", { loggedIn: true });

test/javascripts/acceptance/admin-users-list-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance } from "helpers/qunit-helpers";
 
 acceptance("Admin - Users List", { loggedIn: true });

test/javascripts/acceptance/bookmarks-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import {
   acceptance,
   loggedInUser,

test/javascripts/acceptance/composer-actions-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import selectKit from "helpers/select-kit-helper";
 import { acceptance, updateCurrentUser } from "helpers/qunit-helpers";
 import { _clearSnapshots } from "select-kit/components/composer-actions";

test/javascripts/acceptance/composer-edit-conflict-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance } from "helpers/qunit-helpers";
 import pretender from "helpers/create-pretender";
 

test/javascripts/acceptance/composer-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { run } from "@ember/runloop";
 import selectKit from "helpers/select-kit-helper";
 import { acceptance } from "helpers/qunit-helpers";

test/javascripts/acceptance/forgot-password-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance } from "helpers/qunit-helpers";
 
 let userFound = false;

test/javascripts/acceptance/group-index-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance, updateCurrentUser } from "helpers/qunit-helpers";
 
 acceptance("Group Members");

test/javascripts/acceptance/group-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import selectKit from "helpers/select-kit-helper";
 import { acceptance } from "helpers/qunit-helpers";
 import pretender from "helpers/create-pretender";

test/javascripts/acceptance/groups-new-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance } from "helpers/qunit-helpers";
 
 acceptance("New Group");

test/javascripts/acceptance/login-with-email-and-hide-email-address-taken-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance } from "helpers/qunit-helpers";
 import pretender from "helpers/create-pretender";
 

test/javascripts/acceptance/login-with-email-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance } from "helpers/qunit-helpers";
 
 let userFound = false;

test/javascripts/acceptance/password-reset-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance } from "helpers/qunit-helpers";
 import PreloadStore from "discourse/lib/preload-store";
 import { parsePostData } from "helpers/create-pretender";

test/javascripts/acceptance/personal-message-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance } from "helpers/qunit-helpers";
 
 acceptance("Personal Message", {

test/javascripts/acceptance/preferences-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance, updateCurrentUser } from "helpers/qunit-helpers";
 import selectKit from "helpers/select-kit-helper";
 

test/javascripts/acceptance/topic-footer-buttons-mobile-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import selectKit from "helpers/select-kit-helper";
 import { withPluginApi } from "discourse/lib/plugin-api";
 import { clearTopicFooterButtons } from "discourse/lib/register-topic-footer-button";

test/javascripts/acceptance/topic-move-posts-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance } from "helpers/qunit-helpers";
 acceptance("Topic move posts", { loggedIn: true });
 

test/javascripts/acceptance/topic-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { withPluginApi } from "discourse/lib/plugin-api";
 import selectKit from "helpers/select-kit-helper";
 import { acceptance } from "helpers/qunit-helpers";

test/javascripts/admin/components/themes-list-item-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import componentTest from "helpers/component-test";
 import Theme from "admin/models/theme";
 

test/javascripts/admin/components/themes-list-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import componentTest from "helpers/component-test";
 import Theme, { THEMES, COMPONENTS } from "admin/models/theme";
 

test/javascripts/components/d-button-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import componentTest from "helpers/component-test";
 moduleForComponent("d-button", { integration: true });
 

test/javascripts/components/d-editor-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { next } from "@ember/runloop";
 import { clearToolbarCallbacks } from "discourse/components/d-editor";
 import componentTest from "helpers/component-test";

test/javascripts/components/secret-value-list-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import componentTest from "helpers/component-test";
 moduleForComponent("secret-value-list", { integration: true });
 

test/javascripts/components/select-kit/category-chooser-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import componentTest from "helpers/component-test";
 import { testSelectKitModule } from "helpers/select-kit-helper";
 

test/javascripts/components/select-kit/category-drop-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import DiscourseURL from "discourse/lib/url";
 import Category from "discourse/models/category";
 import componentTest from "helpers/component-test";

test/javascripts/components/select-kit/mini-tag-chooser-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import componentTest from "helpers/component-test";
 import { testSelectKitModule } from "helpers/select-kit-helper";
 

test/javascripts/components/select-kit/single-select-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import componentTest from "helpers/component-test";
 import { testSelectKitModule } from "helpers/select-kit-helper";
 

test/javascripts/components/select-kit/tag-drop-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import componentTest from "helpers/component-test";
 import { testSelectKitModule } from "helpers/select-kit-helper";
 import Site from "discourse/models/site";

test/javascripts/components/select-kit/topic-notifications-button-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import selectKit from "helpers/select-kit-helper";
 import componentTest from "helpers/component-test";
 import Topic from "discourse/models/topic";

test/javascripts/components/select-kit/topic-notifications-options-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import selectKit from "helpers/select-kit-helper";
 import componentTest from "helpers/component-test";
 import Topic from "discourse/models/topic";

test/javascripts/components/text-field-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import componentTest from "helpers/component-test";
 
 moduleForComponent("text-field", { integration: true });

test/javascripts/controllers/create-account-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { mapRoutes } from "discourse/mapping-router";
 
 moduleFor("controller:create-account", "controller:create-account", {

test/javascripts/fixtures/topic.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 /*jshint maxlen:10000000 */
 export default {
   "/t/280/1.json": {

test/javascripts/initializers/localization-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import LocalizationInitializer from "discourse/initializers/localization";
 
 QUnit.module("initializer:localization", {

test/javascripts/lib/computed-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import EmberObject from "@ember/object";
 import {
   setting,

test/javascripts/lib/i18n-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 QUnit.module("lib:i18n", {
   _locale: I18n.locale,
   _fallbackLocale: I18n.fallbackLocale,

test/javascripts/lib/search-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import {
   translateResults,
   searchContextDescription

test/javascripts/lib/uploads-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import {
   validateUploadedFiles,
   authorizedExtensions,

test/javascripts/models/user-drafts-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import UserDraft from "discourse/models/user-draft";
 import { NEW_TOPIC_KEY } from "discourse/models/composer";
 import User from "discourse/models/user";

test/javascripts/widgets/post-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import EmberObject from "@ember/object";
 import { moduleForWidget, widgetTest } from "helpers/widget-test";
 

test/javascripts/widgets/user-menu-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import DiscourseURL from "discourse/lib/url";
 import { moduleForWidget, widgetTest } from "helpers/widget-test";
 

test/javascripts/widgets/widget-dropdown-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { moduleForWidget, widgetTest } from "helpers/widget-test";
 
 moduleForWidget("widget-dropdown");

test/javascripts/widgets/widget-test.js

@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { next } from "@ember/runloop";
 import { moduleForWidget, widgetTest } from "helpers/widget-test";
 import { createWidget } from "discourse/widgets/widget";

yarn.lock

@@ -978,10 +978,10 @@ escape-string-regexp@^1.0.2, escape-string-regexp@^1.0.5:
   resolved "https://registry.yarnpkg.com/escape-string-regexp/-/escape-string-regexp-1.0.5.tgz#1b61c0562190a8dff6ae3bb2cf0200ca130b86d4"
   integrity sha1-G2HAViGQqN/2rjuyzwIAyhMLhtQ=
 
-eslint-config-discourse@1.1.1:
+eslint-config-discourse@1.1.2:
-  version "1.1.1"
+  version "1.1.2"
-  resolved "https://registry.yarnpkg.com/eslint-config-discourse/-/eslint-config-discourse-1.1.1.tgz#8a7f7f6f1a388b0e88f5b79145ae2a8b4a13e3d4"
+  resolved "https://registry.yarnpkg.com/eslint-config-discourse/-/eslint-config-discourse-1.1.2.tgz#f8569579ea3fc348a989bbab0780a5c426038744"
-  integrity sha512-b3dp9DOcXYWkPQpXms/bMDy0Scb6DO/nZAAsl5I9yTNhtkx96zZMTp9QEyC8QaCXOTUpIXEE6V+Mpyjtsk3gWg==
+  integrity sha512-yF29RxKyvFvQbnICCGext0rlXzQMm4AZuBxqOVFonjb0sUbB/08l/FyLHmXKpKgLCEMV6RrJKB7xxPL6twtUkA==
   dependencies:
     babel-eslint "^8.2"
     eslint "^4.19"