Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: Allow group members to freely exit group option incorrectly disabled. 

https://meta.discourse.org/t/cannot-check-allow-members-to-leave-group-freely-when-group-is-configured-to-allow-users-to-send-membership-requests-to-group-owners/73400
This commit is contained in:
Guo Xiang Tan 2017-11-06 10:30:58 +08:00
parent 4e618aa08f
commit abdfac9cb5
3 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/javascripts/discourse/templates/group-edit.hbs
View File

@ -33,8 +33,7 @@
<label> <label>
{{input type='checkbox' {{input type='checkbox'
checked=model.public_exit checked=model.public_exit
class="group-edit-public-exit" class="group-edit-public-exit"}}
disabled=model.allow_membership_requests}}
{{i18n 'groups.public_exit'}} {{i18n 'groups.public_exit'}}
</label> </label>

5
test/javascripts/acceptance/group-edit-test.js.es6
View File

@ -43,6 +43,11 @@ QUnit.test("Editing group", assert => {
'it should disable group public admission input' 'it should disable group public admission input'
); );
assert.ok(
find('.group-edit-public-exit[disabled]').length === 0,
'it should not disable group public exit input'
);
assert.equal( assert.equal(
find('.group-edit-membership-request-template').length, 1, find('.group-edit-membership-request-template').length, 1,
'it should display the membership request template field' 'it should display the membership request template field'

2
test/javascripts/fixtures/group-fixtures.js.es6
View File

@ -9,7 +9,7 @@ export default {
"alias_level":99, "alias_level":99,
"visible":true, "visible":true,
"public_admission":true, "public_admission":true,
"public_exit":true, "public_exit":false,
"flair_url": 'fa-adjust', "flair_url": 'fa-adjust',
"is_group_owner":true, "is_group_owner":true,
"mentionable":true, "mentionable":true,