Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

UX: Always show avatar on mobile topic lists (#15323)

This commit is contained in:
Kris 2021-12-15 20:31:03 -05:00 committed by GitHub
parent 7039046d9e
commit ad4faf637c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 41 additions and 54 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/app/components/basic-topic-list.js
View File

@ -6,8 +6,6 @@ export default Component.extend({
loadingMore: alias("topicList.loadingMore"), loadingMore: alias("topicList.loadingMore"),
loading: not("loaded"), loading: not("loaded"),
hideMobileAvatar: true,
@discourseComputed("topicList.loaded") @discourseComputed("topicList.loaded")
loaded() { loaded() {
let topicList = this.topicList; let topicList = this.topicList;

5
app/assets/javascripts/discourse/app/components/topic-list-item.js
View File

@ -195,11 +195,6 @@ export default Component.extend({
return false; return false;
}, },
@discourseComputed("expandPinned", "hideMobileAvatar")
showMobileAvatar(expandPinned, hideMobileAvatar) {
return !(hideMobileAvatar || expandPinned);
},
showEntrance, showEntrance,
click(e) { click(e) {

1
app/assets/javascripts/discourse/app/templates/components/basic-topic-list.hbs
View File

@ -2,7 +2,6 @@
{{#if topics}} {{#if topics}}
{{topic-list {{topic-list
showPosters=showPosters showPosters=showPosters
hideMobileAvatar=hideMobileAvatar
hideCategory=hideCategory hideCategory=hideCategory
topics=topics topics=topics
expandExcerpts=expandExcerpts expandExcerpts=expandExcerpts

1
app/assets/javascripts/discourse/app/templates/components/topic-list.hbs
View File

@ -36,7 +36,6 @@
showTopicPostBadges=showTopicPostBadges showTopicPostBadges=showTopicPostBadges
hideCategory=hideCategory hideCategory=hideCategory
showPosters=showPosters showPosters=showPosters
hideMobileAvatar=hideMobileAvatar
showLikes=showLikes showLikes=showLikes
showOpLikes=showOpLikes showOpLikes=showOpLikes
expandGloballyPinned=expandGloballyPinned expandGloballyPinned=expandGloballyPinned

4
app/assets/javascripts/discourse/app/templates/mobile/list/topic-list-item.hbr
View File

@ -1,13 +1,9 @@
<td class="topic-list-data"> <td class="topic-list-data">
{{~raw-plugin-outlet name="topic-list-before-columns"}} {{~raw-plugin-outlet name="topic-list-before-columns"}}
{{~#if showMobileAvatar}}
<div class='pull-left'> <div class='pull-left'>
<a href="{{topic.lastPostUrl}}" data-user-card="{{topic.last_poster_username}}">{{avatar topic.lastPosterUser imageSize="large"}}</a> <a href="{{topic.lastPostUrl}}" data-user-card="{{topic.last_poster_username}}">{{avatar topic.lastPosterUser imageSize="large"}}</a>
</div> </div>
<div class='right'> <div class='right'>
{{else}}
<div>
{{/if~}}
{{!-- {{!--
The `~` syntax strip spaces between the elements, making it produce The `~` syntax strip spaces between the elements, making it produce
`<a class=topic-post-badges>Some text</a><span class=topic-post-badges>`, `<a class=topic-post-badges>Some text</a><span class=topic-post-badges>`,