From ad5d16af8ed0257fd14ed54d060946dbda6f8db1 Mon Sep 17 00:00:00 2001 From: Neil Lalonde Date: Wed, 7 Dec 2016 12:40:44 -0500 Subject: [PATCH] FIX: summary email popular posts ordering by score, and increase minimum score to qualify as popular --- app/mailers/user_notifications.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/mailers/user_notifications.rb b/app/mailers/user_notifications.rb index b4f2b76559b..be7956973b6 100644 --- a/app/mailers/user_notifications.rb +++ b/app/mailers/user_notifications.rb @@ -136,11 +136,11 @@ class UserNotifications < ActionMailer::Base @other_new_for_you = topics_for_digest.size > SiteSetting.digest_topics ? topics_for_digest[SiteSetting.digest_topics..-1] : [] @popular_posts = if SiteSetting.digest_posts > 0 - Post.for_mailing_list(user, min_date) + Post.order("posts.score DESC") + .for_mailing_list(user, min_date) .where('posts.post_type = ?', Post.types[:regular]) .where('posts.deleted_at IS NULL AND posts.hidden = false AND posts.user_deleted = false') - .where("posts.post_number > ? AND posts.score > ?", 1, 5.0) - .order("posts.score DESC") + .where("posts.post_number > ? AND posts.score > ?", 1, ScoreCalculator.default_score_weights[:like_score] * 5.0) .limit(SiteSetting.digest_posts) else []