FIX: ensures edited message is correctly re-decorated (#20637)

This commit is contained in:
Joffrey JAFFEUX 2023-03-10 17:06:13 +01:00 committed by GitHub
parent 60ce3d24fa
commit ada89d6124
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 27 additions and 10 deletions

View File

@ -632,7 +632,7 @@ export default class ChatLivePane extends Component {
handleRefreshMessage(data) {
const message = this.args.channel.findMessage(data.chat_message.id);
if (message) {
message.version = message.version + 1;
message.incrementVersion();
}
}
@ -644,6 +644,7 @@ export default class ChatLivePane extends Component {
message.excerpt = data.chat_message.excerpt;
message.uploads = cloneJSON(data.chat_message.uploads || []);
message.edited = true;
message.incrementVersion();
}
}

View File

@ -123,6 +123,10 @@ export default class ChatMessage {
return this.channel?.messages?.objectAt?.(this.index + 1);
}
incrementVersion() {
this.version++;
}
react(emoji, action, actor, currentUserId) {
const selfReaction = actor.id === currentUserId;
const existingReaction = this.reactions.find(

View File

@ -5,18 +5,21 @@ RSpec.describe "Edited message", type: :system, js: true do
let(:channel_page) { PageObjects::Pages::ChatChannel.new }
fab!(:current_user) { Fabricate(:user) }
fab!(:editing_user) { Fabricate(:user) }
fab!(:channel_1) { Fabricate(:category_channel) }
fab!(:message_1) { Fabricate(:chat_message, chat_channel: channel_1, user: editing_user) }
before do
chat_system_bootstrap
channel_1.add(current_user)
channel_1.add(editing_user)
sign_in(current_user)
end
context "when editing message" do
context "with multiple users in the channel" do
fab!(:editing_user) { Fabricate(:user) }
fab!(:message_1) { Fabricate(:chat_message, chat_channel: channel_1, user: editing_user) }
before { channel_1.add(editing_user) }
it "shows as edited for all users" do
chat_page.visit_channel(channel_1)
@ -30,4 +33,13 @@ RSpec.describe "Edited message", type: :system, js: true do
expect(page).to have_content(I18n.t("js.chat.edited"))
end
end
it "runs decorators on the edited message" do
message_1 = Fabricate(:chat_message, chat_channel: channel_1, user: current_user)
chat_page.visit_channel(channel_1)
channel_page.edit_message(message_1, '[date=2025-03-10 timezone="Europe/Paris"]')
expect(page).to have_css(".cooked-date")
end
end
end