Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PERF: Avoid running redundant bookmarks query for anon viewing topic (#19659) 

The `TopicView#bookmarks` method is called by `TopicViewSerializer` and `PostSerializer`
so we want to avoid running a meaningless query when user is not
present.
This commit is contained in:
Alan Guo Xiang Tan 2023-01-03 10:00:36 +08:00 committed by GitHub
parent 24db6fbb73
commit af76f291e6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/topic_view.rb
View File

@ -412,12 +412,13 @@ class TopicView
end end
def has_bookmarks? def has_bookmarks?
return false if @user.blank?
return false if @topic.trashed?
bookmarks.any? bookmarks.any?
end end
def bookmarks def bookmarks
return [] if @user.blank?
return [] if @topic.trashed?
@bookmarks ||= Bookmark.for_user_in_topic(@user, @topic.id).select( @bookmarks ||= Bookmark.for_user_in_topic(@user, @topic.id).select(
:id, :bookmarkable_id, :bookmarkable_type, :reminder_at, :name, :auto_delete_preference :id, :bookmarkable_id, :bookmarkable_type, :reminder_at, :name, :auto_delete_preference
) )