Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: `HtmlToMarkdown` didn't support `tfoot` in tables

This commit is contained in:
Gerhard Schlager 2024-06-09 13:26:39 +02:00 committed by Gerhard Schlager
parent 52e81582b4
commit b01905c724
2 changed files with 32 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/html_to_markdown.rb
View File

@ -220,7 +220,7 @@ class HtmlToMarkdown
"\n\n#{traverse(node)}\n\n"
end
TRAVERSABLES ||= %w[aside font span thead tbody tfooter u]
TRAVERSABLES ||= %w[aside font span thead tbody tfoot u]
TRAVERSABLES.each { |tag| define_method("visit_#{tag}") { |node| traverse(node) } }
def visit_tt(node)

53
spec/lib/html_to_markdown_spec.rb
View File

@ -527,6 +527,14 @@ RSpec.describe HtmlToMarkdown do
<td>line</td>
</tr>
</tbody>
<tfoot>
<tr>
<td>This</td>
<td>is</td>
<td>the</td>
<td>footer</td>
</tr>
</tfoot>
</table>
HTML
@ -535,6 +543,7 @@ RSpec.describe HtmlToMarkdown do
| - | - | - | - |
| I am | the | **first** | row |
| And this | is the | 2<sup>nd</sup> | line |
| This | is | the | footer |
MD
expect(html_to_markdown(html)).to eq(markdown.strip)
@ -565,24 +574,24 @@ RSpec.describe HtmlToMarkdown do
<table>
<tr>
<th>
1
</th>
<th>
2
</th>
<th>
3
</th>
<th>
4
</th>
</tr>
<tr>
@ -592,12 +601,12 @@ RSpec.describe HtmlToMarkdown do
</td>
<td>
**Two**
</td>
<td>
Three
</td>
@ -625,14 +634,14 @@ RSpec.describe HtmlToMarkdown do
<table>
<tr>
<th>
1
</th>
<th>
2
</th>
</tr>
<tr>
@ -671,31 +680,31 @@ RSpec.describe HtmlToMarkdown do
<th>
1
</th>
<th>
2
</th>
</tr>
<tr>
<td>
A
</td>
<td rowspan="2">
B
</td>
</tr>
<tr>
<td>
C
</td>
</tr>
</table>