Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SECURITY: Remove indication that a group exists if user can't see it. 

Minor security fix but we should not leak any hints that a group exists
even if a user does not have access to the group.
This commit is contained in:
Guo Xiang Tan 2020-09-08 10:52:29 +08:00
parent 5ed84d9885
commit b0f22f2523
No known key found for this signature in database
GPG Key ID: FBD110179AAC1F20
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/groups_controller.rb
View File

@ -629,7 +629,7 @@ class GroupsController < ApplicationController
def find_group(param_name, ensure_can_see: true) def find_group(param_name, ensure_can_see: true)
name = params.require(param_name) name = params.require(param_name)
group = Group.find_by("LOWER(name) = ?", name.downcase) group = Group.find_by("LOWER(name) = ?", name.downcase)
guardian.ensure_can_see!(group) if ensure_can_see raise Discourse::NotFound if ensure_can_see && !guardian.can_see_group?(group)
group group
end end

8
spec/requests/groups_controller_spec.rb
View File

@ -357,7 +357,7 @@ describe GroupsController do
get "/groups/#{group.name}.json" get "/groups/#{group.name}.json"
expect(response.status).to eq(403) expect(response.status).to eq(404)
end end
it "returns the right response" do it "returns the right response" do
@ -430,7 +430,7 @@ describe GroupsController do
get "/groups/#{group.name}/posts.json" get "/groups/#{group.name}/posts.json"
expect(response.status).to eq(403) expect(response.status).to eq(404)
end end
it "ensures the group members can be seen" do it "ensures the group members can be seen" do
@ -473,7 +473,7 @@ describe GroupsController do
get "/groups/#{group.name}/members.json" get "/groups/#{group.name}/members.json"
expect(response.status).to eq(403) expect(response.status).to eq(404)
end end
it "ensures the group members can be seen" do it "ensures the group members can be seen" do
@ -1888,7 +1888,7 @@ describe GroupsController do
get "/groups/#{group.name}/permissions.json" get "/groups/#{group.name}/permissions.json"
expect(response.status).to eq(403) expect(response.status).to eq(404)
end end
describe "with varying category permissions" do describe "with varying category permissions" do