Clean up update_visit_record!

update_visit_record! appears to add user_visit record if one
doesn't exist and days_visited is simply a counter for the number
of visit records.
This commit is contained in:
Leonard Garvey 2013-05-18 16:02:06 +10:00
parent 32f4dfd2fb
commit b16705be0d
1 changed files with 2 additions and 11 deletions

View File

@ -325,10 +325,6 @@ class User < ActiveRecord::Base
self.password_hash == hash_password(password, salt)
end
def seen?(date)
last_seen_at.to_date >= date if last_seen_at.present?
end
def seen_before?
last_seen_at.present?
end
@ -338,14 +334,9 @@ class User < ActiveRecord::Base
end
def update_visit_record!(date)
unless seen_before?
unless has_visit_record?(date)
update_column(:days_visited, days_visited + 1)
user_visits.create!(visited_at: date)
update_column(:days_visited, 1)
end
unless seen?(date) || has_visit_record?(date)
user_visits.create!(visited_at: date)
User.update_all('days_visited = days_visited + 1', id: self.id)
end
end