Discource-C/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-21 11:25:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Move preloaded json into <discourse-assets> element (#17145)

Browse Source 
This PR introduces 0 visual or functional changes. The only thing that it changes is that it moves the data-preloaded div (which has the app boot json into the <discourse-assets> element.

See #17078 for a bit more context.

The reason behind this change is that it makes devTools element view a little bit less cluttered.
This commit is contained in:
Joe 2022-06-20 16:39:11 +08:00 committed by GitHub
parent 9361d9a587
commit b2bf1db36f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/discourse/app/index.html
View File

@ -25,6 +25,9 @@
<bootstrap-content key="discourse-stylesheets">
{{content-for "discourse-stylesheets"}}
</discourse-assets-stylesheets>
<discourse-assets-json>
<bootstrap-content key="preloaded">
</discourse-assets-json>
</discourse-assets>
<bootstrap-content key="body">
@ -34,7 +37,6 @@
</section>
<bootstrap-content key="hidden-login-form">
<bootstrap-content key="preloaded">
<script defer src="{{rootURL}}assets/start-discourse.js"></script>

4
app/views/layouts/application.html.erb
View File

@ -75,6 +75,9 @@
<discourse-assets-stylesheets>
<%= render partial: "common/discourse_stylesheet" %>
</discourse-assets-stylesheets>
<discourse-assets-json>
<div class="hidden" id="data-preloaded" data-preloaded="<%= preloaded_json %>"></div>
</discourse-assets-json>
</discourse-assets>
<%- if allow_plugins? %>
@ -114,7 +117,6 @@
</form>
<% end %>
<div class="hidden" id="data-preloaded" data-preloaded="<%= preloaded_json %>"></div>
<script defer src="<%= script_asset_path "start-discourse" %>"></script>