REFACTOR: Test assertions should be imported.

Previously they were global functions.

.eslintignore

@@ -12,6 +12,5 @@ public/
 vendor/
 app/assets/javascripts/discourse/tests/test_helper.js
 app/assets/javascripts/discourse/tests/fixtures
-app/assets/javascripts/discourse/tests/helpers/assertions.js
 node_modules/
 dist/

.eslintrc

@@ -10,5 +10,8 @@
     "testDone": "off",
     "sinon": "off",
     "currentURL": "off",
+    "invisible": "off",
+    "visible": "off",
+    "count": "off",
   }
 }

.prettierignore

@@ -20,7 +20,6 @@ public/
 vendor/
 app/assets/javascripts/discourse/tests/test_helper.js
 app/assets/javascripts/discourse/tests/fixtures
-app/assets/javascripts/discourse/tests/helpers/assertions.js
 node_modules/
 dist/
 **/*.rb

app/assets/javascripts/discourse/tests/acceptance/about-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/account-created-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit, click, fillIn } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/admin-search-log-term-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/admin-search-logs-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/admin-site-settings-test.js

@@ -1,6 +1,7 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { fillIn, click, visit, currentURL } from "@ember/test-helpers";
 import { test } from "qunit";
-import { acceptance } from "discourse/tests/helpers/qunit-helpers";
+import { acceptance, count } from "discourse/tests/helpers/qunit-helpers";
 import siteSettingFixture from "discourse/tests/fixtures/site-settings";
 
 acceptance("Admin - Site Settings", function (needs) {

app/assets/javascripts/discourse/tests/acceptance/admin-site-text-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { fillIn, click, visit, currentURL } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/admin-suspend-user-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit, click, fillIn } from "@ember/test-helpers";
 import { test } from "qunit";
 import selectKit from "discourse/tests/helpers/select-kit-helper";

app/assets/javascripts/discourse/tests/acceptance/admin-user-badges-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/admin-users-list-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import I18n from "I18n";

app/assets/javascripts/discourse/tests/acceptance/admin-watched-words-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { fillIn, click, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/auth-complete-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/badges-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import selectKit from "discourse/tests/helpers/select-kit-helper";

app/assets/javascripts/discourse/tests/acceptance/bookmarks-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, fillIn, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import I18n from "I18n";

app/assets/javascripts/discourse/tests/acceptance/category-banner-test.js

@@ -1,6 +1,6 @@
 import { click, visit } from "@ember/test-helpers";
 import { test } from "qunit";
-import { acceptance } from "discourse/tests/helpers/qunit-helpers";
+import { acceptance, visible } from "discourse/tests/helpers/qunit-helpers";
 import DiscoveryFixtures from "discourse/tests/fixtures/discovery-fixtures";
 
 acceptance("Category Banners", function (needs) {

app/assets/javascripts/discourse/tests/acceptance/category-edit-test.js

@@ -1,9 +1,9 @@
 import { click, fillIn, visit, currentURL } from "@ember/test-helpers";
 import { test } from "qunit";
 import selectKit from "discourse/tests/helpers/select-kit-helper";
-import { acceptance } from "discourse/tests/helpers/qunit-helpers";
 import DiscourseURL from "discourse/lib/url";
 import sinon from "sinon";
+import { acceptance, visible } from "discourse/tests/helpers/qunit-helpers";
 
 acceptance("Category Edit", function (needs) {
   needs.user();

app/assets/javascripts/discourse/tests/acceptance/composer-actions-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, fillIn, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import I18n from "I18n";

app/assets/javascripts/discourse/tests/acceptance/composer-hyperlink-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, fillIn, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/composer-test.js

@@ -1,10 +1,14 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, fillIn, visit, currentURL } from "@ember/test-helpers";
-import { skip } from "qunit";
+import { skip, test } from "qunit";
-import { test } from "qunit";
 import I18n from "I18n";
 import { run } from "@ember/runloop";
 import selectKit from "discourse/tests/helpers/select-kit-helper";
-import { acceptance } from "discourse/tests/helpers/qunit-helpers";
+import {
+  acceptance,
+  invisible,
+  visible,
+} from "discourse/tests/helpers/qunit-helpers";
 import { toggleCheckDraftPopup } from "discourse/controllers/composer";
 import Draft from "discourse/models/draft";
 import { Promise } from "rsvp";

app/assets/javascripts/discourse/tests/acceptance/composer-topic-links-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, fillIn, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/composer-uncategorized-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, fillIn, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import selectKit from "discourse/tests/helpers/select-kit-helper";

app/assets/javascripts/discourse/tests/acceptance/create-account-external-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/create-account-user-fields-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, fillIn, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/custom-html-set-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/dashboard-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, fillIn, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import selectKit from "discourse/tests/helpers/select-kit-helper";

app/assets/javascripts/discourse/tests/acceptance/email-notice-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import {

app/assets/javascripts/discourse/tests/acceptance/emoji-picker-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, fillIn, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/encoded-category-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/flag-post-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import selectKit from "discourse/tests/helpers/select-kit-helper";

app/assets/javascripts/discourse/tests/acceptance/forgot-password-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, fillIn, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import I18n from "I18n";

app/assets/javascripts/discourse/tests/acceptance/group-index-test.js

@@ -4,6 +4,7 @@ import I18n from "I18n";
 import {
   acceptance,
   updateCurrentUser,
+  count,
 } from "discourse/tests/helpers/qunit-helpers";
 
 acceptance("Group Members - Anonymous", function () {

app/assets/javascripts/discourse/tests/acceptance/group-manage-categories-test.js

@@ -3,6 +3,7 @@ import { test } from "qunit";
 import {
   acceptance,
   updateCurrentUser,
+  count,
 } from "discourse/tests/helpers/qunit-helpers";
 
 acceptance("Managing Group Category Notification Defaults", function () {

app/assets/javascripts/discourse/tests/acceptance/group-manage-profile-test.js

@@ -3,6 +3,7 @@ import { test } from "qunit";
 import {
   acceptance,
   updateCurrentUser,
+  count,
 } from "discourse/tests/helpers/qunit-helpers";
 
 acceptance("Managing Group Profile", function () {

app/assets/javascripts/discourse/tests/acceptance/group-manage-tags-test.js

@@ -3,6 +3,7 @@ import { test } from "qunit";
 import {
   acceptance,
   updateCurrentUser,
+  count,
 } from "discourse/tests/helpers/qunit-helpers";
 
 acceptance("Managing Group Tag Notification Defaults", function () {

app/assets/javascripts/discourse/tests/acceptance/group-test.js

@@ -2,7 +2,7 @@ import { click, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import I18n from "I18n";
 import selectKit from "discourse/tests/helpers/select-kit-helper";
-import { acceptance } from "discourse/tests/helpers/qunit-helpers";
+import { acceptance, count } from "discourse/tests/helpers/qunit-helpers";
 
 function setupGroupPretender(server, helper) {
   server.post("/groups/Macdonald/request_membership", () => {

app/assets/javascripts/discourse/tests/acceptance/groups-index-test.js

@@ -1,6 +1,11 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, visit } from "@ember/test-helpers";
 import { test } from "qunit";
-import { acceptance } from "discourse/tests/helpers/qunit-helpers";
+import {
+  acceptance,
+  invisible,
+  count,
+} from "discourse/tests/helpers/qunit-helpers";
 
 acceptance("Groups", function () {
   test("Browsing Groups", async (assert) => {

app/assets/javascripts/discourse/tests/acceptance/invite-accept-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { fillIn, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/invite-show-user-fields-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { fillIn, click, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/jump-to-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, fillIn, visit, currentURL } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/login-required-test.js

@@ -1,6 +1,7 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, visit } from "@ember/test-helpers";
 import { test } from "qunit";
-import { acceptance } from "discourse/tests/helpers/qunit-helpers";
+import { acceptance, invisible } from "discourse/tests/helpers/qunit-helpers";
 
 acceptance("Login Required", function (needs) {
   needs.settings({ login_required: true });

app/assets/javascripts/discourse/tests/acceptance/login-with-email-and-no-social-logins-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/login-with-email-disabled-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/login-with-email-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { fillIn, click, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import I18n from "I18n";

app/assets/javascripts/discourse/tests/acceptance/mobile-discovery-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/mobile-sign-in-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/mobile-users-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/new-message-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/new-topic-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import selectKit from "discourse/tests/helpers/select-kit-helper";

app/assets/javascripts/discourse/tests/acceptance/page-publishing-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, fillIn, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/password-reset-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit, click, fillIn } from "@ember/test-helpers";
 import { test } from "qunit";
 import I18n from "I18n";

app/assets/javascripts/discourse/tests/acceptance/personal-message-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import I18n from "I18n";

app/assets/javascripts/discourse/tests/acceptance/plugin-outlet-decorator-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/post-admin-menu-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit, click } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/preferences-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit, currentURL, click, fillIn } from "@ember/test-helpers";
 import { test } from "qunit";
 import I18n from "I18n";

app/assets/javascripts/discourse/tests/acceptance/reports-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/search-full-test.js

@@ -1,11 +1,12 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit, fillIn, click } from "@ember/test-helpers";
-import { skip } from "qunit";
+import { skip, test } from "qunit";
-import { test } from "qunit";
 import selectKit from "discourse/tests/helpers/select-kit-helper";
 import {
   selectDate,
   acceptance,
   waitFor,
+  visible,
 } from "discourse/tests/helpers/qunit-helpers";
 
 acceptance("Search - Full Page", function (needs) {

app/assets/javascripts/discourse/tests/acceptance/search-mobile-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, fillIn, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/search-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, fillIn, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import selectKit from "discourse/tests/helpers/select-kit-helper";

app/assets/javascripts/discourse/tests/acceptance/share-and-invite-desktop-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/share-and-invite-mobile-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import selectKit from "discourse/tests/helpers/select-kit-helper";

app/assets/javascripts/discourse/tests/acceptance/sign-in-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, fillIn, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/static-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/tags-intersection-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/tags-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import {

app/assets/javascripts/discourse/tests/acceptance/topic-admin-menu-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import {

app/assets/javascripts/discourse/tests/acceptance/topic-anonymous-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/topic-discovery-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import DiscourseURL from "discourse/lib/url";

app/assets/javascripts/discourse/tests/acceptance/topic-quote-button-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import I18n from "I18n";

app/assets/javascripts/discourse/tests/acceptance/topic-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, fillIn, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import I18n from "I18n";

app/assets/javascripts/discourse/tests/acceptance/unknown-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit, currentURL } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/user-anonymous-test.js

@@ -1,6 +1,7 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit, currentURL } from "@ember/test-helpers";
 import { test } from "qunit";
-import { acceptance } from "discourse/tests/helpers/qunit-helpers";
+import { acceptance, count } from "discourse/tests/helpers/qunit-helpers";
 
 acceptance("User Anonymous", function () {
   test("Root URL", async (assert) => {

app/assets/javascripts/discourse/tests/acceptance/user-bookmarks-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { click, visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/user-card-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/user-preferences-interface-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/user-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/acceptance/users-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { visit } from "@ember/test-helpers";
 import { test } from "qunit";
 import { acceptance } from "discourse/tests/helpers/qunit-helpers";

app/assets/javascripts/discourse/tests/helpers/assertions.js

@@ -1,21 +0,0 @@
-// discourse-skip-module
-function exists(selector) {
-  return count(selector) > 0;
-}
-
-function count(selector) {
-  return find(selector).length;
-}
-
-function visible(selector) {
-  return find(selector + ":visible").length > 0;
-}
-
-function invisible(selector) {
-  const $items = find(selector + ":visible");
-  return (
-    $items.length === 0 ||
-    $items.css("opacity") !== "1" ||
-    $items.css("visibility") === "hidden"
-  );
-}

app/assets/javascripts/discourse/tests/helpers/qunit-helpers.js

@@ -374,3 +374,24 @@ export async function selectDate(selector, date) {
     resolve();
   });
 }
+
+export function invisible(selector) {
+  const $items = find(selector + ":visible");
+  return (
+    $items.length === 0 ||
+    $items.css("opacity") !== "1" ||
+    $items.css("visibility") === "hidden"
+  );
+}
+
+export function visible(selector) {
+  return find(selector + ":visible").length > 0;
+}
+
+export function count(selector) {
+  return find(selector).length;
+}
+
+export function exists(selector) {
+  return count(selector) > 0;
+}

app/assets/javascripts/discourse/tests/helpers/select-kit-helper.js

@@ -1,6 +1,7 @@
 import { moduleForComponent } from "ember-qunit";
 import { isEmpty } from "@ember/utils";
 import { click, fillIn } from "@ember/test-helpers";
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 
 function checkSelectKitIsNotExpanded(selector) {
   if (find(selector).hasClass("is-expanded")) {

app/assets/javascripts/discourse/tests/integration/components/admin-report-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { moduleForComponent } from "ember-qunit";
 import componentTest from "discourse/tests/helpers/component-test";
 import pretender from "discourse/tests/helpers/create-pretender";

app/assets/javascripts/discourse/tests/integration/components/d-button-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { moduleForComponent } from "ember-qunit";
 import I18n from "I18n";
 import componentTest from "discourse/tests/helpers/component-test";

app/assets/javascripts/discourse/tests/integration/components/date-time-input-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { moduleForComponent } from "ember-qunit";
 import componentTest from "discourse/tests/helpers/component-test";
 import { click } from "@ember/test-helpers";

app/assets/javascripts/discourse/tests/integration/components/html-safe-helper-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { moduleForComponent } from "ember-qunit";
 import componentTest from "discourse/tests/helpers/component-test";
 moduleForComponent("html-safe-helper", { integration: true });

app/assets/javascripts/discourse/tests/integration/components/select-kit/category-drop-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import I18n from "I18n";
 import DiscourseURL from "discourse/lib/url";
 import Category from "discourse/models/category";

app/assets/javascripts/discourse/tests/integration/components/select-kit/combo-box-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { moduleForComponent } from "ember-qunit";
 import selectKit from "discourse/tests/helpers/select-kit-helper";
 import componentTest from "discourse/tests/helpers/component-test";

app/assets/javascripts/discourse/tests/integration/components/select-kit/dropdown-select-box-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { moduleForComponent } from "ember-qunit";
 import selectKit from "discourse/tests/helpers/select-kit-helper";
 import componentTest from "discourse/tests/helpers/component-test";

app/assets/javascripts/discourse/tests/integration/widgets/header-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import {
   moduleForWidget,
   widgetTest,

app/assets/javascripts/discourse/tests/integration/widgets/topic-admin-menu-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import {
   moduleForWidget,
   widgetTest,

app/assets/javascripts/discourse/tests/integration/widgets/topic-participant-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import {
   moduleForWidget,
   widgetTest,

app/assets/javascripts/discourse/tests/integration/widgets/widget-dropdown-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import I18n from "I18n";
 import {
   moduleForWidget,

app/assets/javascripts/discourse/tests/setup-tests.js

@@ -15,6 +15,7 @@ import { ScrollingDOMMethods } from "discourse/mixins/scrolling";
 import {
   resetSite,
   applyPretender,
+  exists,
 } from "discourse/tests/helpers/qunit-helpers";
 import PreloadStore from "discourse/lib/preload-store";
 import User from "discourse/models/user";
@@ -78,6 +79,18 @@ export default function setupTests(app, container) {
       return window.sinon;
     },
   });
+  Object.defineProperty(window, "exists", {
+    get() {
+      deprecated(
+        "Accessing the global function `exists` is deprecated. Import it instead.",
+        {
+          since: "2.6.0.beta.4",
+          dropFrom: "2.6.0",
+        }
+      );
+      return exists;
+    },
+  });
 
   QUnit.testStart(function (ctx) {
     let settings = resetSettings();

app/assets/javascripts/discourse/tests/unit/utils/decorators-test.js

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import { afterRender } from "discourse-common/utils/decorators";
 import Component from "@ember/component";
 import componentTest from "discourse/tests/helpers/component-test";

app/assets/javascripts/wizard/test/acceptance/wizard-test.js

@@ -14,6 +14,10 @@ module("Acceptance: wizard", {
   },
 });
 
+function exists(selector) {
+  return document.querySelector(selector) !== null;
+}
+
 test("Wizard starts", async (assert) => {
   await visit("/");
   assert.ok(exists(".wizard-column-contents"));

app/assets/javascripts/wizard/test/test_helper.js

@@ -17,7 +17,6 @@
 //= require ember-template-compiler
 //= require wizard-application
 //= require wizard-vendor
-//= require helpers/assertions
 //= require_tree ./helpers
 //= require_tree ./acceptance
 //= require_tree ./models

plugins/poll/test/javascripts/acceptance/poll-builder-disabled-test.js.es6

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import {
   acceptance,
   updateCurrentUser,

plugins/poll/test/javascripts/acceptance/poll-builder-enabled-test.js.es6

@@ -1,3 +1,4 @@
+import { exists } from "discourse/tests/helpers/qunit-helpers";
 import selectKit from "discourse/tests/helpers/select-kit-helper";
 import {
   acceptance,