From b364a13ad3142666cd7ec576b13090d1d3379a0a Mon Sep 17 00:00:00 2001
From: David Taylor <david@taylorhq.com>
Date: Tue, 29 Oct 2024 11:11:10 +0000
Subject: [PATCH] DEV: Update dynamic component hbs syntax (#29445)

The block form of `{{#component` is not supported by Glint tooling. They recommend using this `{{#let`-based syntax to achieve the same result
---
 .../discourse/app/components/reviewable-item.hbs   | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/app/assets/javascripts/discourse/app/components/reviewable-item.hbs b/app/assets/javascripts/discourse/app/components/reviewable-item.hbs
index f8587d6e2ab..09b8d4c3ae5 100644
--- a/app/assets/javascripts/discourse/app/components/reviewable-item.hbs
+++ b/app/assets/javascripts/discourse/app/components/reviewable-item.hbs
@@ -55,11 +55,17 @@
         {{/each}}
       </div>
     {{else}}
-      {{#component
-        this.reviewableComponent reviewable=this.reviewable tagName=""
+      {{#let
+        (component
+          this.reviewableComponent reviewable=this.reviewable tagName=""
+        )
+        as |ReviewableComponent|
       }}
-        <ReviewableScores @reviewable={{this.reviewable}} @tagName="" />
-      {{/component}}
+        {{! template-lint-disable no-shadowed-elements }}{{! (seems to be a false positive) }}
+        <ReviewableComponent>
+          <ReviewableScores @reviewable={{this.reviewable}} @tagName="" />
+        </ReviewableComponent>
+      {{/let}}
     {{/if}}
   </div>