From b3a028acc004e60912e5b46463c3598e28609119 Mon Sep 17 00:00:00 2001 From: Jeff Atwood Date: Sun, 27 Mar 2016 09:29:27 -0700 Subject: [PATCH] remove built-in support for bbcode size --- .../discourse/dialects/bbcode_dialect.js | 5 ----- app/assets/stylesheets/common/base/bbcode.scss | 6 ------ test/javascripts/lib/bbcode-test.js.es6 | 14 -------------- 3 files changed, 25 deletions(-) diff --git a/app/assets/javascripts/discourse/dialects/bbcode_dialect.js b/app/assets/javascripts/discourse/dialects/bbcode_dialect.js index 079bb014acb..b13441cfd14 100644 --- a/app/assets/javascripts/discourse/dialects/bbcode_dialect.js +++ b/app/assets/javascripts/discourse/dialects/bbcode_dialect.js @@ -169,11 +169,6 @@ Discourse.BBCode.replaceBBCodeParamsRaw("email", function(param, contents) { return ['a', {href: "mailto:" + param, 'data-bbcode': true}].concat(contents); }); -Discourse.BBCode.register('size', function(contents, params) { - return ['span', {'class': "bbcode-size-" + (parseInt(params, 10) || 1)}].concat(contents); -}); -Discourse.Markdown.whiteListTag('span', 'class', /^bbcode-size-\d+$/); - // Handles `[code] ... [/code]` blocks Discourse.Dialect.replaceBlock({ start: /(\[code\])([\s\S]*)/igm, diff --git a/app/assets/stylesheets/common/base/bbcode.scss b/app/assets/stylesheets/common/base/bbcode.scss index b2ff87815b1..f40d8ac9a7f 100644 --- a/app/assets/stylesheets/common/base/bbcode.scss +++ b/app/assets/stylesheets/common/base/bbcode.scss @@ -13,10 +13,4 @@ span { &.bbcode-s { text-decoration: line-through; } - // Font sizes - @for $i from 4 through 40 { - &.bbcode-size-#{$i} { - font-size: #{$i}px; - } - } } diff --git a/test/javascripts/lib/bbcode-test.js.es6 b/test/javascripts/lib/bbcode-test.js.es6 index 34b3992b843..86ca8d685e2 100644 --- a/test/javascripts/lib/bbcode-test.js.es6 +++ b/test/javascripts/lib/bbcode-test.js.es6 @@ -62,20 +62,6 @@ test('tags with arguments', function() { format("[b]first[/b] [b]second[/b]", "first second", "can bold two things on the same line"); }); -test("size tags", function() { - format("[size=35]BIG [b]whoop[/b][/size]", - "BIG whoop", - "supports [size=]"); - format("[size=asdf]regular[/size]", - "regular", - "it only supports numbers in bbcode"); - format("[size=35]NEWLINE\n\ntest[/size]", - "

NEWLINE

test

", - "works with newlines"); - format("[size=35][quote=\"user\"]quote[/quote][/size]", - "", - "works with nested complex blocks"); -}); test("quotes", function() {