Discource-C/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-21 03:19:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

FIX: more resilient dates separators computation (#21370)

Browse Source 
In the past this was happening on scroll so we needed to be very conservative here. Also, if we wait too much theres a visible element flashing so this PR attempts to compute right away, and a second time 100ms later in case the first one happened too early.
This commit is contained in:
Joffrey JAFFEUX 2023-05-03 21:29:18 +02:00 committed by GitHub
parent 4f306cf88f
commit b46899e5fa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
plugins/chat/assets/javascripts/discourse/components/chat-channel.js
View File

@ -8,7 +8,7 @@ import { action } from "@ember/object";
import { handleStagedMessage } from "discourse/plugins/chat/discourse/services/chat-pane-base-subscriptions-manager";
import { ajax } from "discourse/lib/ajax";
import { popupAjaxError } from "discourse/lib/ajax-error";
import { cancel, schedule, throttle } from "@ember/runloop";
import { cancel, later, schedule } from "@ember/runloop";
import discourseLater from "discourse-common/lib/later";
import { inject as service } from "@ember/service";
import { Promise } from "rsvp";
@ -86,6 +86,7 @@ export default class ChatLivePane extends Component {
removeOnPresenceChange(this.onPresenceChangeCallback);
this._unsubscribeToUpdates(this._loadedChannelId);
this.requestedTargetMessageId = null;
cancel(this._laterComputeHandler);
}
@action
@ -862,7 +863,9 @@ export default class ChatLivePane extends Component {
@action
computeDatesSeparators() {
throttle(this, this._computeDatesSeparators, 50, true);
cancel(this._laterComputeHandler);
this._computeDatesSeparators();
this._laterComputeHandler = later(this, this.computeDatesSeparators, 100);
}
// A more consistent way to scroll to the bottom when we are sure this is our goal